This repository has been archived by the owner. It is now read-only.

Added --enable-double-precision option to ode formula #13912

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@benureau

benureau commented Aug 3, 2012

Sometimes, you need ODE in double precision. This makes it convenient. I adapted the code for the imagemagick formula. I hope this is the right way to do it.

@benureau

This comment has been minimized.

Show comment
Hide comment
@benureau

benureau Aug 21, 2012

Could somebody could take a look at this pull request ? It's small, uncontroversial and useful.

Could somebody could take a look at this pull request ? It's small, uncontroversial and useful.

@swrede

This comment has been minimized.

Show comment
Hide comment
@swrede

swrede Oct 2, 2012

+1 for this pull request. The current formula is causing really unnecessary documentation issues if one wants double precision.

swrede commented Oct 2, 2012

+1 for this pull request. The current formula is causing really unnecessary documentation issues if one wants double precision.

@Juxi

This comment has been minimized.

Show comment
Hide comment
@Juxi

Juxi Oct 2, 2012

Contributor

+1 for this pull request also from me.
without it getting double precision in ode is a bit of a hack...

Contributor

Juxi commented Oct 2, 2012

+1 for this pull request also from me.
without it getting double precision in ode is a bit of a hack...

@adamv

This comment has been minimized.

Show comment
Hide comment
@adamv

adamv Oct 28, 2012

Contributor

Is there a reason this should not always be enabled? What if we end up with things that depend on ODE being compiled both ways?

Contributor

adamv commented Oct 28, 2012

Is there a reason this should not always be enabled? What if we end up with things that depend on ODE being compiled both ways?

@benureau

This comment has been minimized.

Show comment
Hide comment
@benureau

benureau Oct 28, 2012

We have two choices :

  1. The careful one : we just add the possibility of double precision through an option. It doesn't affect anybody (anymore than now) unless people that know what they are doing.
  2. The optimist one : we activate double precision by default. I don't know enough about this issue to recommend or argue against such a decision.

We have two choices :

  1. The careful one : we just add the possibility of double precision through an option. It doesn't affect anybody (anymore than now) unless people that know what they are doing.
  2. The optimist one : we activate double precision by default. I don't know enough about this issue to recommend or argue against such a decision.

@adamv adamv closed this in 8fdf612 Jan 8, 2013

dholm added a commit to dholm/homebrew that referenced this pull request Jan 14, 2013

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

@benureau benureau deleted the benureau:odedouble branch Mar 29, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.