Added --enable-double-precision option to ode formula #13912

Closed
wants to merge 1 commit into
from

4 participants

@humm

Sometimes, you need ODE in double precision. This makes it convenient. I adapted the code for the imagemagick formula. I hope this is the right way to do it.

@humm

Could somebody could take a look at this pull request ? It's small, uncontroversial and useful.

@swrede

+1 for this pull request. The current formula is causing really unnecessary documentation issues if one wants double precision.

@Juxi

+1 for this pull request also from me.
without it getting double precision in ode is a bit of a hack...

@adamv

Is there a reason this should not always be enabled? What if we end up with things that depend on ODE being compiled both ways?

@humm

We have two choices :
1. The careful one : we just add the possibility of double precision through an option. It doesn't affect anybody (anymore than now) unless people that know what they are doing.
2. The optimist one : we activate double precision by default. I don't know enough about this issue to recommend or argue against such a decision.

@adamv adamv added a commit that closed this pull request Jan 8, 2013
@humm humm ode: add --enable-double-precision
Closes #13912.
8fdf612
@adamv adamv closed this in 8fdf612 Jan 8, 2013
@yourabi yourabi added a commit that referenced this pull request Jan 9, 2013
@humm humm ode: add --enable-double-precision
Closes #13912.
776d8ce
@dholm dholm added a commit to dholm/homebrew that referenced this pull request Jan 14, 2013
@humm humm ode: add --enable-double-precision
Closes #13912.
a1a4312
@rajeeja rajeeja pushed a commit that referenced this pull request Apr 19, 2013
@humm humm ode: add --enable-double-precision
Closes #13912.
74c14ed
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016
@humm humm deleted the humm:odedouble branch Mar 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.