This repository has been archived by the owner. It is now read-only.

LLVM 3.1: fix compilation of Ocaml bindings #14125

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@matbd

matbd commented Aug 11, 2012

The problem is that generating the documentation (with ocamldoc) seems to require some object files (.cmi) to be already available. For a quick fix I patched the Makefile so that the global target 'docs' comes after 'bindings'.

I also patched 2 sub-Makefiles where I suspect that the target 'ocamldoc' was hiding the intended default target.

The resulting patch on LLVM is kinda huge unfortunately...

I tested this formula with "brew install --build-from-source llvm" on MAC OS Lion with Ocaml 4.00.

@Sharpie

This comment has been minimized.

Show comment Hide comment
@Sharpie

Sharpie Aug 11, 2012

Contributor

That is indeed a big patch. In these cases we like to see large changes pushed upstream before we start carrying them around as patches.

Contributor

Sharpie commented Aug 11, 2012

That is indeed a big patch. In these cases we like to see large changes pushed upstream before we start carrying them around as patches.

@MikeMcQuaid

This comment has been minimized.

Show comment Hide comment
@MikeMcQuaid

MikeMcQuaid Aug 11, 2012

Member

Particularly just to fix ocaml bindings.

Member

MikeMcQuaid commented Aug 11, 2012

Particularly just to fix ocaml bindings.

@matbd

This comment has been minimized.

Show comment Hide comment
@matbd

matbd Aug 13, 2012

Sure, no worries. At least we now have a public patch to start the conversation with the LLVM team.

matbd commented Aug 13, 2012

Sure, no worries. At least we now have a public patch to start the conversation with the LLVM team.

@MikeMcQuaid

This comment has been minimized.

Show comment Hide comment
@MikeMcQuaid

MikeMcQuaid Aug 13, 2012

Member

Indeed, thanks @mathieubt. Patches are great but they (like salmon) naturally want to go upstream.

Member

MikeMcQuaid commented Aug 13, 2012

Indeed, thanks @mathieubt. Patches are great but they (like salmon) naturally want to go upstream.

@adamv

This comment has been minimized.

Show comment Hide comment
@adamv

adamv Oct 20, 2012

Contributor

Seems that we're passing on this; in any case the patch doesn't apply on the current LLVM formula. Please feel free to update if there is something we should check here.

Contributor

adamv commented Oct 20, 2012

Seems that we're passing on this; in any case the patch doesn't apply on the current LLVM formula. Please feel free to update if there is something we should check here.

@adamv adamv closed this Oct 20, 2012

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.