This repository has been archived by the owner. It is now read-only.

libcroco: Xcode-only fix #14207

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

samueljohn commented Aug 15, 2012

UPDATE 2:

ENV.libxml2 was missing.

Contributor

samueljohn commented Aug 15, 2012

Hmm or this is an Xcode-only issue, and it should use the libxml2 from "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk/usr/include/libxml2/"

Contributor

2bits commented Aug 15, 2012

Well I don't understand how it found libxml2 in your cellar. It's keg only.

Contributor

samueljohn commented Aug 15, 2012

Sorry, I was not clear. The 'libxml' was not found on my system so I added depends_on 'libxml'. The otool output is from after that.

But I think, I have to teach libcroco to use the system's libxml. An xcode-only issue here.

I will update the pull request and rephrase the title to reflect that.

Contributor

samueljohn commented Aug 15, 2012

commit and topic changed.

Contributor

jacknagel commented Aug 21, 2012

So libxml2 headers are always under MacOS.sdk_path for Xcode-only installs? Maybe ENV.libxml2 should be updated to reflect this instead.

Contributor

jacknagel commented Aug 21, 2012

Actually it already does this. So probably what we need here is a call to ENV.libxml2 instead?

Contributor

samueljohn commented Aug 21, 2012

I'll test if ENV.libxml2 does the trick.

Member

mxcl commented Aug 21, 2012

Fixed by superenv. Or ENV.libxml2 should work pre-superenv. If not it should probably be adjusted to add the sdk_path’s libxml2 for nclt.

Contributor

samueljohn commented Aug 21, 2012

What is superenv?
Without any modification, this formula does not build on my Xcode only system.
ENV.libxml2 does work, indeed. I re-push-ed.

Contributor

jacknagel commented Aug 23, 2012

Thanks.

@jacknagel jacknagel closed this in d149ef8 Aug 23, 2012

Sharpie pushed a commit to Sharpie/homebrew that referenced this pull request Sep 12, 2012

libcroco: needs ENV.libxml2 for Xcode-only
Closes #14207.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012

libcroco: needs ENV.libxml2 for Xcode-only
Closes #14207.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.