This repository has been archived by the owner. It is now read-only.

New formula: `duti` #14276

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@mathiasbynens
Contributor

mathiasbynens commented Aug 18, 2012

duti is a command-line tool to select default applications for document types and URL schemes on OS X.

+ url 'http://downloads.sourceforge.net/project/duti/duti/duti-1.5.0/duti-1.5.0.tar.gz'
+ sha1 '105553ef2a5e63adc348f8247f727b5671d884ce'
+
+ depends_on 'autoconf' => :build

This comment has been minimized.

Show comment Hide comment
@jacknagel

jacknagel Aug 21, 2012

Contributor

Does it require our autoconf on all platforms, or just with Xcode 4.3+? If it's the latter, we have a special :autoconf dependency to handle that case.

@jacknagel

jacknagel Aug 21, 2012

Contributor

Does it require our autoconf on all platforms, or just with Xcode 4.3+? If it's the latter, we have a special :autoconf dependency to handle that case.

This comment has been minimized.

Show comment Hide comment
@mathiasbynens

mathiasbynens Aug 21, 2012

Contributor

On all platforms, AFAIK. But thanks for the info — I’m new to this whole creating Homebrew formulae thing and didn’t know about :autoconf.

@mathiasbynens

mathiasbynens Aug 21, 2012

Contributor

On all platforms, AFAIK. But thanks for the info — I’m new to this whole creating Homebrew formulae thing and didn’t know about :autoconf.

@jacknagel

View changes

Library/Formula/duti.rb
+ end
+
+ def test
+ system "duti", "-x", "txt"

This comment has been minimized.

Show comment Hide comment
@jacknagel

jacknagel Aug 21, 2012

Contributor

Use the full path to the executable: "#{bin}/duti"

@jacknagel

jacknagel Aug 21, 2012

Contributor

Use the full path to the executable: "#{bin}/duti"

@jacknagel

View changes

Library/Formula/duti.rb
+
+ def patches
+ # Fixes compilation on OS X 10.7 and 10.8
+ # Patch taken from here: http://mths.be/bit

This comment has been minimized.

Show comment Hide comment
@jacknagel

jacknagel Aug 21, 2012

Contributor

Please don't use URL shorteners

@jacknagel

jacknagel Aug 21, 2012

Contributor

Please don't use URL shorteners

This comment has been minimized.

Show comment Hide comment
@mathiasbynens

mathiasbynens Aug 21, 2012

Contributor

I only did so because the full URL is 114 characters (>80) long :) Will remove, and change the other stuff you suggested.

@mathiasbynens

mathiasbynens Aug 21, 2012

Contributor

I only did so because the full URL is 114 characters (>80) long :) Will remove, and change the other stuff you suggested.

@jacknagel

View changes

Library/Formula/duti.rb
+ system "duti", "-x", "txt"
+ end
+
+ def patches

This comment has been minimized.

Show comment Hide comment
@jacknagel

jacknagel Aug 21, 2012

Contributor

def patches goes above def install by convention

@jacknagel

jacknagel Aug 21, 2012

Contributor

def patches goes above def install by convention

Add formula for `duti`
Signed-off-by: Mathias Bynens <mathias@qiwi.be>
@mathiasbynens

This comment has been minimized.

Show comment Hide comment
@mathiasbynens

mathiasbynens Aug 21, 2012

Contributor

@jacknagel I’ve applied your suggestions and submitted a new patch here: #14330. Closing this pull request.

Contributor

mathiasbynens commented Aug 21, 2012

@jacknagel I’ve applied your suggestions and submitted a new patch here: #14330. Closing this pull request.

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.