valgrind 3.8.0 #14323

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@rizzatti
Contributor
  • changes checksum to sha1
  • comments on CFLAGS requirements for 10.8
  • add download url for HEAD
  • runs autogen for HEAD build
@mrnugget

+1 on this since I can't get the current version installed on Mountain Lion

@rizzatti
Contributor

@adamv I'll make the change to require autotools if building head.

@jacknagel there was a reference to the constant already on the file, so I just tried being consistent. I can change everything to conform to your suggestion.

@rizzatti rizzatti valgrind 3.8.0
* changes checksum to sha1
* comments on CFLAGS requirements for 10.8
* add download url for HEAD
* add autoconf as dependency for HEAD
* runs autogen for HEAD build
* changes references to MACOS_VERSION to MacOS.version
bf92df0
@rizzatti
Contributor

@adamv @jacknagel updated the pull request with the changes.

@jacknagel
Contributor

@adamv we need an audit check for MACOS_VERSION (should use MacOS.version).

@rizzatti
Contributor

@jacknagel do you mean in general, for other formulas? or is there something I'm still missing?

@rizzatti
Contributor

btw, as a tip for me, is it really ok to just force an update on a branch linked to a pull request?

@jacknagel
Contributor

(a) in general (b) yep.

@jacknagel
Contributor

Thanks.

@jacknagel jacknagel added a commit that closed this pull request Aug 23, 2012
@rizzatti @jacknagel rizzatti + jacknagel valgrind 3.8.0
* changes checksum to sha1
* comments on CFLAGS requirements for 10.8
* add download url for HEAD
* add autotools as dependency for HEAD
* runs autogen for HEAD build
* changes references to MACOS_VERSION to MacOS.version

Closes #14323.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
c59910e
@jacknagel jacknagel closed this in c59910e Aug 23, 2012
@Sharpie Sharpie pushed a commit to Sharpie/homebrew that referenced this pull request Sep 12, 2012
@rizzatti @jacknagel rizzatti + jacknagel valgrind 3.8.0
* changes checksum to sha1
* comments on CFLAGS requirements for 10.8
* add download url for HEAD
* add autotools as dependency for HEAD
* runs autogen for HEAD build
* changes references to MACOS_VERSION to MacOS.version

Closes #14323.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2df6b0e
@snakeyroc3 snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012
@rizzatti @jacknagel rizzatti + jacknagel valgrind 3.8.0
* changes checksum to sha1
* comments on CFLAGS requirements for 10.8
* add download url for HEAD
* add autotools as dependency for HEAD
* runs autogen for HEAD build
* changes references to MACOS_VERSION to MacOS.version

Closes #14323.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
84a3383
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.