This repository has been archived by the owner. It is now read-only.

Added formula for fon-flash #14561

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
@nolith
Contributor

nolith commented Aug 30, 2012

This formula compiles fon-flash, an ethernet flashing tool for routers.
This formula will only compile the command line tool.

Added formula for fon-flash
This formula compiles fon-flash, an ethernet flashing tool for routers.
This formula will only compile the command line tool.
Library/Formula/fon-flash-cli.rb
+
+class FonFlashCli < Formula
+ homepage 'http://www.gargoyle-router.com/wiki/doku.php?id=fon_flash'
+ url 'http://www.gargoyle-router.com/downloads/fon-flash/fon-flash-src.tar.gz'

This comment has been minimized.

Show comment Hide comment
@jacknagel

jacknagel Aug 30, 2012

Contributor

Need a stable (versioned) URL

@jacknagel

jacknagel Aug 30, 2012

Contributor

Need a stable (versioned) URL

This comment has been minimized.

Show comment Hide comment
@nolith

nolith Aug 30, 2012

Contributor

they didn't provide it.
The source code is part of a bigger repo and the fon-flash folder is 3 years old.
The tool itsel isn't versioned.

@nolith

nolith Aug 30, 2012

Contributor

they didn't provide it.
The source code is part of a bigger repo and the fon-flash folder is 3 years old.
The tool itsel isn't versioned.

This comment has been minimized.

Show comment Hide comment
@jacknagel

jacknagel Aug 30, 2012

Contributor

Options are then to (a) ask upstream to provide a versioned download or (b) this can go in an external repo; we can't accept non-versioned downloads into core.

@jacknagel

jacknagel Aug 30, 2012

Contributor

Options are then to (a) ask upstream to provide a versioned download or (b) this can go in an external repo; we can't accept non-versioned downloads into core.

This comment has been minimized.

Show comment Hide comment
@nolith

nolith Aug 30, 2012

Contributor

Ok, I'll ask a versioned url.

@nolith

nolith Aug 30, 2012

Contributor

Ok, I'll ask a versioned url.

@nolith

This comment has been minimized.

Show comment Hide comment
@nolith

nolith Aug 30, 2012

Contributor

I've found a versioned download of the whole gargoyle firmware, wich includes fon-flash tool.
May this be enough? If it's ok I'll provide a squashed commit.

Thank you

Contributor

nolith commented Aug 30, 2012

I've found a versioned download of the whole gargoyle firmware, wich includes fon-flash tool.
May this be enough? If it's ok I'll provide a squashed commit.

Thank you

Library/Formula/fon-flash-cli.rb
+
+ def install
+ system "cd fon-flash; make fon-flash"
+ bin.install 'fon-flash/fon-flash'

This comment has been minimized.

Show comment Hide comment
@jacknagel

jacknagel Sep 3, 2012

Contributor

Can just do

cd 'fon-flash' do
  system "make fon-flash"
  bin.install 'fon-flash'
end
@jacknagel

jacknagel Sep 3, 2012

Contributor

Can just do

cd 'fon-flash' do
  system "make fon-flash"
  bin.install 'fon-flash'
end
Library/Formula/fon-flash-cli.rb
+ end
+
+ def test
+ system "fon-flash"

This comment has been minimized.

Show comment Hide comment
@jacknagel

jacknagel Sep 3, 2012

Contributor

Use full path in the test: #{bin}/fon-flash

@jacknagel

jacknagel Sep 3, 2012

Contributor

Use full path in the test: #{bin}/fon-flash

@adamv adamv closed this in bafbc50 Oct 3, 2012

snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012

fon-flash-cli 1.5.6
Closes #14561.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.