upgrade to glassfish 3.1.2.2 and fix glassfish pkg & updatetool path problem #14744

Closed
wants to merge 2 commits into from

4 participants

@phstudy

upgrade version from 3.1.2 to 3.1.2.2
install .org.opensolaris,pkg under libexec, so you can use pkg & updatetool

@phstudy phstudy Update Library/Formula/glassfish.rb
1.update version from 3.1.2 to 3.1.2.2 
2.install .org.opensolaris,pkg under libexec, so you can use pkg & updatetool
3d0a015
@adamv

If this has a self-updater, then maybe we shouldn't be packaging it (since the version changes.)

Can you provide more information out what updatetool does?

@phstudy phstudy Update Library/Formula/glassfish.rb
refix pkg and updatetool path problem
change md5 to sha1

glassfish updatetool is used to manage and update glassfish Add-ons
57db849
@phstudy

I think we should package updatetool.
updatetool is not only a self-updater, but also is an add-on components and modules manager.

If we do not package updatetool, we have to add components and modules manually.

@adamv

We can't have software in a versioned folder being updated to a different version; can you link me to some documentation on this?

@phstudy

Formula android-sdk's update tool 'android' script is doing the same thing as Formula glassfish's 'updatetool' script
They are both self-updaters and also can use to add packages.

Android SDK Documentation about Android SDK Manager
http://developer.android.com/sdk/installing/adding-packages.html

@MikeMcQuaid
Homebrew member

As long as Glassfish isn't updating itself I'm happy.

@mxcl
Homebrew member

If it is like the android formula then it should put the things that are installed in #{var} so they survive upgrades.

For adam and mike: the android formula installs the android tool, this installs the actual SDKs to var, you pick and choose which sdks and the android tool keeps them up to date. Homebrew doesn't and should not manage the SDKs as the android tool is designed for that.

The android formula also has a bunch of other stuff though.

@phstudy

Android formula only installs add-ons, platforms, sources, temp, extras, samples and system-images to var.

The platform-tools(Android SDK Platform-tools) and tools(Android SDK Tools) are still installed in Cellar/android-sdk folder, and can be updated to new version via android tools (glassfish updatetool is the same)

Is there a sample or guideline for such case?

Thanks :)

@adamv

Please squash to a single commit for review; the first line of the commit message should be of the form name version. Sorry for the delay in reviewing this.

@adamv adamv added a commit that closed this pull request Jan 9, 2013
@phstudy phstudy glassfish 3.1.2.2
Closes #14744.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
0e93aaa
@adamv adamv closed this in 0e93aaa Jan 9, 2013
@yourabi yourabi added a commit that referenced this pull request Jan 9, 2013
@phstudy phstudy glassfish 3.1.2.2
Closes #14744.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
d5dd174
@dholm dholm added a commit to dholm/homebrew that referenced this pull request Jan 14, 2013
@phstudy phstudy glassfish 3.1.2.2
Closes #14744.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
8711026
@rajeeja rajeeja pushed a commit that referenced this pull request Apr 19, 2013
@phstudy phstudy glassfish 3.1.2.2
Closes #14744.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
7cf32d7
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.