This repository has been archived by the owner. It is now read-only.

New formula: rpm (version 4.x) #14937

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
Contributor

2bits commented Sep 14, 2012

  • Add rpm formula at version 4.10.1
  • Enable lua bindings. Requires lua-5.1. Works well.
  • Enable python bindings. Works great.
  • Uses bdb, nss, nspr, libmagic, xz, pkg-config
  • Has a patch, not mine, explained in the PR.
  • Docs are disabled because they're online.

Closes #11188

Contributor

adamv commented Sep 14, 2012

I'm not keen on carrying a patch, but rpm is "very requested" so I'm willing to pull a working formula.

Contributor

2bits commented Sep 14, 2012

Anyone know who crafted the patch?

Contributor

afb commented Sep 14, 2012

The rpm.org upstream is not very keen on taking patches either, but one might give it another try.
There was lua-5.2 support implemented in rpm-5.4 last year or so, but reimplemented in cce1818.

The patch from cab6a16 was refactored in 7cd93bd, I believe it comes from the original
glibc __progname workarounds from 10 years ago or so. Plus some minor BSD compat hacks.

Contributor

afb commented Sep 14, 2012

Basically the patches in #14937 came from the original pull requests: #11188 and #8090
It's just that they lost that history during the rebasing of 5f69d15 to the latest master.

Contributor

afb commented Sep 14, 2012

@2bits: the doxygen apidocs were renamed to "hackingdocs" and disabled by default, by rpm.org*
Normally they are disabled for size reasons, there's an online version at http://rpm.org/api/4.10.0/

Contributor

afb commented Sep 14, 2012

Squashed: 961cecbe59e3a62191c46510b2667d12eaedc953

Contributor

2bits commented Sep 14, 2012

Thanks for getting back on it. I couldn't figure how to fix the LUA_GLOBALSINDEX. So that'll be good to have. I'd be happy with either of our formulas.

Contributor

2bits commented Oct 7, 2012

@adamv @jacknagel Let's consider adding this as 'rpm' and crafting a separate formula for rpm5 like Adam suggested. I think this is ready, but I may have to figure out the status of all the patches and report any issues they aren't tracking.

@afb I'd like to add my rpm-4.10.0 formula without the lua patch at first. After it's accepted, you can open a PR to patch for LUA-5.2. That way the admins can choose what to do about lua by pulling in your patch or reverting to lua-5.1.

Contributor

afb commented Oct 13, 2012

@2bits I upgraded the formula to 4.10.1 and changed it to use an array for configure like you did. I replaced the inline patch with a link to upstream, which should not be needed for 4.10.2 and beyond. You can find it at 472a32fba03ef0800a502076cb318554ef35ac39, and then squash and rebase it to the latest master ? Someone else would need to get the Darwin patches upstream...

Contributor

2bits commented Nov 14, 2012

It looks like Homebrew reverted to lua-5.1 for now. That means I can adjust this formula to build with lua and for the latest rpm v4.x. I still think Homebrew should have both rpm and rpm5 in the main repo. I rebase and update soon.

nibbles 2bits
New formula: rpm (version 4.x)
- Add rpm formula at version 4.10.1
- Enable lua bindings against lua-5.1. Works now.
- Enable python bindings. Works great.
- Uses bdb, nss, nspr, libmagic, xz, pkg-config.
- Has a patch, not mine, explained in the PR.
- Docs are disabled because they're online.

Closes #11188
Contributor

2bits commented Nov 14, 2012

@adamv @jacknagel Please review when you have some time.

Owner

MikeMcQuaid commented Nov 14, 2012

I'd rather we didn't have rpm and rpm5 formulae.

Contributor

2bits commented Nov 14, 2012

I would tend to agree, but rpm and rpm5 are totally different projects.

Contributor

afb commented Nov 16, 2012

@2bits the patched version works with any lua version (5.1 or 5.2) now, so that doesn't really matter...

@MikeMcQuaid you mean you don't want any rpm in homebrew ? or that you can't choose which org ?

Owner

MikeMcQuaid commented Nov 16, 2012

No, I mean I'd like either rpm or rpm5 not both.

What's wrong with having both? I don't see any problem with having more options.

Owner

MikeMcQuaid commented Nov 17, 2012

It's confusing for users, we don't tend to do so and I'd rather we didn't maintain more than one.

Contributor

afb commented Nov 18, 2012

If you are going to actually maintain it, you probably need someone to work on getting those patches upstream ?
Possibly including some of the other patches already accumulated by the (Japanese) OSXWS apt-rpm project...

Owner

MikeMcQuaid commented Nov 18, 2012

Or we just use rpm5 which doesn't require any patches?

Contributor

afb commented Nov 18, 2012

http://www.bach-phys.ritsumei.ac.jp/OSXWS/MountainLion/SRPMS.main/rpm-4.10.1-1osx10.8.src.rpm
Filtering out all the distribution idiosyncrasies (inherited from Vine Linux) before actually applying, that is.

Contributor

afb commented Nov 18, 2012

@MikeMcQuaid or that... it would still need an interested maintainer for upstream development, though ?
Both for any new features (like porting from gcc to llvm), and for testing and extending the existing ones.

@2bits 2bits closed this Nov 18, 2012

afb added a commit to afb/homebrew that referenced this pull request May 1, 2013

New formula: rpm 4.11
- Add rpm formula at version 4.11.0.1
  (brown paper bag release of 4.11.x)
- Enable default lua and python bindings.
- Docs are disabled because they're online.
- Added portability patches (from 5f69d15).

Closes #8090 #11188 #14937

@afb afb referenced this pull request May 1, 2013

Closed

New formula: rpm 4.11 #19557

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.