This repository has been archived by the owner. It is now read-only.

New Formula: ghostscript-fonts #14949

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
5 participants
Contributor

royhodgman commented Sep 14, 2012

Some aspects of ImageMagick depend on ghostscript fonts, so this formula delivers only the fonts.

This entire formula is cherry picked from the ghostscript.rb Formula.

The inspiration for this came about when trying to work through issue #14609.

Contributor

adamv commented Sep 15, 2012

If a full Ghostscript is installed after this, do things get weird?

Contributor

jacknagel commented Sep 15, 2012

Note that this can be accessed from other code without creating a separate formula.

Something like

require Formula.path("ghostscript")
GhostscriptFonts.new.brew do
  ...
end
Contributor

royhodgman commented Sep 16, 2012

@adamv I did a full ghostscript install after this and it seemed to go fine. It did however redownload the gs fonts archive from source forge.

Contributor

royhodgman commented Sep 16, 2012

@jacknagel If the ghostscript fonts are a distinct download from the main ghostscript distribution and there is a use case for installing the fonts independently from ghostscript, do you think it makes sense to split the fonts out into their own formula and make the ghostscript formula list the fonts as a dependency instead?

Contributor

royhodgman commented Sep 16, 2012

@adamv Nope. Never mind. I did that ghostscript install with a different homebrew prefix which did not have the ghostscipt fonts installed already. My mistake. When I installed ghostscript after installing the ghostscript-fonts formula there was an error with linking:

==> Installing ghostscript
==> Downloading http://downloads.ghostscript.com/public/ghostscript-9.06.tar.gz
Already downloaded: /Library/Caches/Homebrew/ghostscript-9.06.tar.gz
==> Patching
patching file base/unix-dll.mak
==> ./configure --prefix=/usr/local/Cellar/ghostscript/9.06 --disable-cups --disable-compile-inits --disable-gtk --w
==> make install
==> make install-so
==> Downloading http://downloads.sourceforge.net/project/gs-fonts/gs-fonts/8.11%20%28base%2035%2C%20GPL%29/ghostscri
Already downloaded: /Library/Caches/Homebrew/ghostscript-fonts-std-8.11.tar.gz
Warning: Could not link ghostscript. Unlinking...
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
You can try again using `brew link ghostscript'
==> Summary
/usr/local/Cellar/ghostscript/9.06: 709 files, 50M, built in 2.2 minutes

but then when I ran "brew link ghostscript", it seems like things turned out ok:

Linking /usr/local/Cellar/ghostscript/9.06... 66 symlinks created

However, this makes me think that the right way to deal with this is to have two formulas, ghostscript, and ghostscript-fonts where ghostscript lists ghostscript-fonts as a dependency.

royhodgman added some commits Sep 14, 2012

@royhodgman royhodgman New Formula: ghostscript-fonts
Some aspects of ImageMagick depend on ghostscript fonts, so this formula delivers only the fonts.

This entire formula is cherry picked from the ghostscript.rb Formula.

The inspiration for this came about when trying to work through issue #14609.
6069e75
@royhodgman royhodgman making ghostscript depend on ghostscript-fonts. 2aa5dac
@royhodgman royhodgman adding ghostscript-fonts optional dependency to imagemagick. 2fd27de
@royhodgman royhodgman adding ghostscript-fonts optional dependency to graphicsmagick. 32cd0a5
Contributor

royhodgman commented Oct 7, 2012

Now ghostscript depends on ghostscript-fonts, and imagemagick and graphicsmagick have an optional dependency on ghostscript-fonts.

@samueljohn samueljohn commented on the diff Dec 3, 2012

Library/Formula/imagemagick.rb
@@ -113,6 +115,9 @@ def caveats
<<-EOS.undent
Some tools will complain unless the ghostscript fonts are installed to:
@samueljohn

samueljohn Dec 3, 2012

Contributor

Good work. I'd vote to just make the ghostscript-fonts a depends_on without an option and then we don't need this caveat at all.

Contributor

samueljohn commented Dec 3, 2012

I like this split very much. In my opinion, the ghostscript-fonts should just be a dependency without any option or at least only with an option to deactivate (--disable-ghostscript-fonts).

Contributor

adamv commented Jan 17, 2013

Looks like this needs to be rebased on master.

Owner

MikeMcQuaid commented Feb 1, 2013

Closing until rebased. Will reopen when done.

@MikeMcQuaid MikeMcQuaid closed this Feb 1, 2013

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.