libnids: build the shared library #15011

Closed
wants to merge 1 commit into from

3 participants

@2bits

libnids is used by dsniff, but libnids only builds a static library
due to being coded in 2005 before much use of .dylib etc. By
patching libnids to build a shared library, we can get dsniff to
link against it and against glib and gthread correctly without
LDFLAGS hacking.

  • Add deps on automake and libtool to run autoreconf
  • Run autoreconf to fix any issues in 2005 era configure.
  • Add configure flag to --enable-shared
  • Add patch to fix errors building shared with -soname and .so
  • Works well with superenv and dsniff

Fixes #14363

@2bits 2bits libnids: build the shared library
libnids is used by dsniff, but libnids only builds a static library
due to being coded in 2005 before much use of `.dylib` etc.  By
patching libnids to build a shared library, we can get dsniff to
link against it and against glib and gthread correctly without
`LDFLAGS` hacking.

- Add deps on automake anb libtool to run `autoreconf`
- Run autoreconf to fix any issues in 2005 era configure.
- Add configure flag to `--enable-shared`
- Add patch to fix errors building shared with `-soname` and `.so`
- Works well with superenv and dnsiff

Fixes #14363
a407224
@mxcl
Homebrew member
$ brew install libnids
==> Downloading http://downloads.sourceforge.net/project/libnids/libnids/1.24/li
Already downloaded: /Library/Caches/Homebrew/libnids-1.24.tar.gz
==> Patching
patching file src/Makefile.in
Hunk #3 FAILED at 76.
1 out of 3 hunks FAILED -- saving rejects to file src/Makefile.in.rej
Error: Failure while executing: /usr/bin/patch -f -p1 -i 000-homebrew.diff
@2bits

It's a weird patch: brew pull 15011 --ignore-whitespace

@mxcl
Homebrew member

@mikemcquaid anyway to know we need that flag?

@MikeMcQuaid
Homebrew member

@mxcl Not really unfortunately unless we can check the patch contents for intentional whitespace. We could just disable it but then we lose the whitespace fixing it does for many user contributions.

@mxcl
Homebrew member

Should we consider deleting libnids.a so that issues like those in #14363 are not repeated?

@mxcl mxcl added a commit that closed this pull request Sep 24, 2012
@2bits 2bits libnids: build the shared library
libnids is used by dsniff, but libnids only builds a static library
due to being coded in 2005 before much use of `.dylib` etc.  By
patching libnids to build a shared library, we can get dsniff to
link against it and against glib and gthread correctly without
`LDFLAGS` hacking.

- Add deps on automake anb libtool to run `autoreconf`
- Run autoreconf to fix any issues in 2005 era configure.
- Add configure flag to `--enable-shared`
- Add patch to fix errors building shared with `-soname` and `.so`
- Works well with superenv and dnsiff

Fixes #14363

Closes #15011.

Signed-off-by: Max Howell <mxcl@me.com>
214491a
@mxcl mxcl closed this in 214491a Sep 24, 2012
@snakeyroc3 snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012
@2bits 2bits libnids: build the shared library
libnids is used by dsniff, but libnids only builds a static library
due to being coded in 2005 before much use of `.dylib` etc.  By
patching libnids to build a shared library, we can get dsniff to
link against it and against glib and gthread correctly without
`LDFLAGS` hacking.

- Add deps on automake anb libtool to run `autoreconf`
- Run autoreconf to fix any issues in 2005 era configure.
- Add configure flag to `--enable-shared`
- Add patch to fix errors building shared with `-soname` and `.so`
- Works well with superenv and dnsiff

Fixes #14363

Closes #15011.

Signed-off-by: Max Howell <mxcl@me.com>
e91d69e
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.