This repository has been archived by the owner. It is now read-only.

libcanberra 0.29 #15021

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@adammw
Contributor

adammw commented Sep 20, 2012

New formula for libcanberra (aka libcanberra-gtk3).

@mistydemeo

View changes

Library/Formula/libcanberra.rb
+ end
+
+ def patches
+ DATA

This comment has been minimized.

Show comment Hide comment
@mistydemeo

mistydemeo Sep 20, 2012

Contributor

Can you document what this patch is for? Has the issue it resolves been reported upstream?

@mistydemeo

mistydemeo Sep 20, 2012

Contributor

Can you document what this patch is for? Has the issue it resolves been reported upstream?

@mistydemeo

View changes

Library/Formula/libcanberra.rb
+ system "make install"
+ end
+
+ def patches

This comment has been minimized.

Show comment Hide comment
@mistydemeo

mistydemeo Sep 20, 2012

Contributor

patches method usually goes above the install method.

@mistydemeo

mistydemeo Sep 20, 2012

Contributor

patches method usually goes above the install method.

@adammw

This comment has been minimized.

Show comment Hide comment
@adammw

adammw Sep 21, 2012

Contributor

Updated from 631b820 to 8f6525e
@adamv head line moved
@mistydemeo moved patches method, reason for patch is before __END__, has not been reported upstream

Contributor

adammw commented Sep 21, 2012

Updated from 631b820 to 8f6525e
@adamv head line moved
@mistydemeo moved patches method, reason for patch is before __END__, has not been reported upstream

@adammw

This comment has been minimized.

Show comment Hide comment
@adammw

adammw Sep 21, 2012

Contributor

Updated again from 8f6525e to 110547d
Forgot to change ARGV.build_head? to build.head? which I have been told is the standard way of checking for head.

Contributor

adammw commented Sep 21, 2012

Updated again from 8f6525e to 110547d
Forgot to change ARGV.build_head? to build.head? which I have been told is the standard way of checking for head.

@adamv

This comment has been minimized.

Show comment Hide comment
@adamv

adamv Sep 25, 2012

Please add a comment about the source of the patch, and a link to the upstream bug report.

Please add a comment about the source of the patch, and a link to the upstream bug report.

@adamv

This comment has been minimized.

Show comment Hide comment
@adamv

adamv Sep 25, 2012

This version should be auto-detected.

This version should be auto-detected.

@adamv

This comment has been minimized.

Show comment Hide comment
@adamv

adamv Nov 5, 2012

Contributor

We'll need a new pulseaudio formula for review; and we'll probably need this at 0.30.

Contributor

adamv commented Nov 5, 2012

We'll need a new pulseaudio formula for review; and we'll probably need this at 0.30.

@adamv adamv closed this Nov 5, 2012

@adammw adammw referenced this pull request Sep 26, 2013

Closed

libcanberra 0.30 #22853

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.