This repository has been archived by the owner. It is now read-only.

Update rust recipe. #15073

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

awreece commented Sep 24, 2012

add head

build with newest clang

don't hardcode homebrew path

don't patch if building from head

depend on llvm to avoid duplicate package

@mistydemeo mistydemeo and 1 other commented on an outdated diff Sep 24, 2012

Library/Formula/rust.rb
@@ -5,6 +5,10 @@ class Rust < Formula
url 'http://dl.rust-lang.org/dist/rust-0.3.1.tar.gz'
sha256 'eb99ff2e745ecb6eaf01d4caddebce397a2b4cda6836a051cb2d493b9cedd018'
+ depends_on 'llvm'
+
+ head 'https://github.com/mozilla/rust.git'
@mistydemeo

mistydemeo Sep 24, 2012

Contributor

head should go above depends_on, not below.

@awreece

awreece Sep 24, 2012

Contributor

done

@mistydemeo mistydemeo and 1 other commented on an outdated diff Sep 24, 2012

Library/Formula/rust.rb
@@ -5,6 +5,10 @@ class Rust < Formula
url 'http://dl.rust-lang.org/dist/rust-0.3.1.tar.gz'
sha256 'eb99ff2e745ecb6eaf01d4caddebce397a2b4cda6836a051cb2d493b9cedd018'
+ depends_on 'llvm'
+
+ head 'https://github.com/mozilla/rust.git'
+
fails_with :clang do
build 318
@mistydemeo

mistydemeo Sep 24, 2012

Contributor

Were you able to test this with the current version of clang? Does it work now?

@awreece

awreece Sep 24, 2012

Contributor

Yes, this works for both building from head and from the tarball.

Contributor

jacknagel commented Sep 24, 2012

Why do we need a dep on LLVM? Doesn't rust ship its own copy?

Contributor

awreece commented Sep 24, 2012

Yeah it does (ship its own copy), but isn't that something we'd rather avoid?

Contributor

jacknagel commented Sep 24, 2012

Perhaps, but doesn't it merit at least a mention in the commit message?

Contributor

awreece commented Sep 24, 2012

Good call, I accidentally deleted that while rebasing.

Update rust recipe.
add head
build with newest clang
don't hardcode homebrew path
don't patch if building from head
depend on llvm rather than download extra copy
Contributor

adamv commented Oct 24, 2012

Passing on this and letting rust vendor its own LLVM.

@adamv adamv closed this Oct 24, 2012

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.