This repository has been archived by the owner. It is now read-only.

mpfr: add skip-check option #15114

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

afh commented Sep 25, 2012

Make the mpfr formula look and behave more similar to the somewhat related gmp formula.

Additionally I come across the following error when installing with superenv
(IOW: when installing with --env=std it compiles just fine)
clang: error: unable to execute command: Segmentation fault: 11
Can you reproduce the error?

My research revealed that the following workaround prevents the sigsegv:
inreplace "configure", "${wl}-flat_namespace ${wl}-undefined ${wl}suppress", ""
How is this related to superenv?

I get a similar error with mpfr

Edit: I should add that this has only occurred for me when trying to upgrade mpfr as a dependency for libmpc. Don't know if libmpc has anything to do with this or not...

happens to me too, just upgrade xcode to 4.5

Contributor

afh commented Sep 29, 2012

I have Xcode 4.5 and the issue remains

% brew --config
HOMEBREW_VERSION: 0.9.3
HEAD: 55534b7f20c99f4666834dfe3594a640bbe85a89
HOMEBREW_PREFIX: /opt/local
HOMEBREW_CELLAR: /opt/local/Cellar
CPU: 8-core 64-bit ivybridge
OS X: 10.8.2-x86_64
Xcode: 4.5
CLT: 4.5.0.0.1.1249367152
LLVM-GCC: build 2336
Clang: 4.1 build 421
X11: 2.7.2 => /opt/X11
System Ruby: 1.8.7-358
Perl: /usr/bin/perl
Python: /usr/bin/python
Ruby: /usr/bin/ruby => /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/bin/ruby

brew --config
HOMEBREW_VERSION: 0.9.3
HEAD: 55534b7
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CELLAR: /usr/local/Cellar
CPU: dual-core 64-bit penryn
OS X: 10.7.5-x86_64
Xcode: 4.5
CLT: 1.0.0.9000000000.1.1249367152
GCC-4.2: build 5666
LLVM-GCC: build 2335
Clang: 2.1 build 163
X11: => /usr/X11
System Ruby: 1.8.7-358
Perl: /usr/bin/perl
Python: /usr/bin/python
Ruby: /usr/bin/ruby => /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/bin/ruby

Contributor

jacknagel commented Sep 29, 2012

I'm not really a fan of adding more skip-check options for things like this. I think it encourages sacrificing correctness for minimal gain. The test suite doesn't take that long to run, and gmp, mpfr, and libmpc are all things that run a high risk of miscompilation.

Contributor

afh commented Oct 1, 2012

@jacknagel Good point how about removing the --skip-check option from gmp then? ;)

Contributor

jacknagel commented Oct 1, 2012

Totally in favor of that.

adamv added a commit that referenced this pull request Oct 1, 2012

@jacknagel jacknagel closed this Oct 2, 2012

snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.