This repository has been archived by the owner. It is now read-only.

New formula timelimit-1.8 #15167

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@ghxiao
Contributor

ghxiao commented Sep 27, 2012

timelimit executes a command and terminates the spawned process after a given time with a given signal. A “warning” signal is sent first, then, after a timeout, a “kill” signal, similar to the way init(8) operates on shutdown.

@jacknagel

View changes

Library/Formula/timelimit.rb
+ sha1 '0bc20606db0f587f3927f747680c9522b2d4c5af'
+
+ def install
+ system "uid=`id -un`;\\\ngid=`id -gn`;\\\nmake LOCALBASE=#{prefix} BINOWN=$uid BINGRP=$gid MANOWN=$uid MANGRP=$gid MANDIR=#{man}/man install"

This comment has been minimized.

Show comment Hide comment
@jacknagel

jacknagel Sep 28, 2012

Contributor

This needs to be broken up a bit, don't shove everything into one shell invocation.

@jacknagel

jacknagel Sep 28, 2012

Contributor

This needs to be broken up a bit, don't shove everything into one shell invocation.

This comment has been minimized.

Show comment Hide comment
@ghxiao

ghxiao Sep 30, 2012

Contributor

@jacknagel Thanks a lot for you advice, I split the string into strings to make it slightly more readable in the following commit. But this still has to be in one invocation. Otherwise, the values of variables uid and gid will be lost if I put them into different invocations.

@ghxiao

ghxiao Sep 30, 2012

Contributor

@jacknagel Thanks a lot for you advice, I split the string into strings to make it slightly more readable in the following commit. But this still has to be in one invocation. Otherwise, the values of variables uid and gid will be lost if I put them into different invocations.

@adamv

This comment has been minimized.

Show comment Hide comment
@adamv

adamv Oct 14, 2012

Contributor

Also squash down to a single commit

Contributor

adamv commented Oct 14, 2012

Also squash down to a single commit

timelimit 1.8
timelimit executes a command and terminates the spawned process after a given time with a given signal. A “warning” signal is sent first, then, after a timeout, a “kill” signal, similar to the way init(8) operates on shutdown.
@ghxiao

This comment has been minimized.

Show comment Hide comment
@ghxiao

ghxiao Oct 15, 2012

Contributor

@adamv @jacknagel Now I have broken the calls into several lines and get the user name and group name using Ruby directly. Commits have been squashed into single one.

Contributor

ghxiao commented Oct 15, 2012

@adamv @jacknagel Now I have broken the calls into several lines and get the user name and group name using Ruby directly. Commits have been squashed into single one.

@adamv

This comment has been minimized.

Show comment Hide comment
@adamv

adamv Oct 15, 2012

Contributor

Thanks, will try to review this soon.

Contributor

adamv commented Oct 15, 2012

Thanks, will try to review this soon.

@ghost ghost assigned adamv Oct 15, 2012

@adamv

This comment has been minimized.

Show comment Hide comment
@adamv

adamv Oct 21, 2012

Contributor

Are the user and group specifications strictly needed?

Contributor

adamv commented Oct 21, 2012

Are the user and group specifications strictly needed?

@adamv

This comment has been minimized.

Show comment Hide comment
@adamv

adamv Oct 21, 2012

Contributor

I'll just do the install step manually.

Contributor

adamv commented Oct 21, 2012

I'll just do the install step manually.

@adamv adamv closed this in e60f30f Oct 21, 2012

snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012

timelimit 1.8
Closes #15167.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.