Add formula for `pdfsqueeze` #15193

Closed
wants to merge 1 commit into
from

2 participants

@mathiasbynens

No description provided.

@mathiasbynens mathiasbynens Add formula for pdfsqueeze
Signed-off-by: Mathias Bynens <mathias@qiwi.be>
4c301e5
@jacknagel jacknagel commented on the diff Sep 29, 2012
Library/Formula/pdfsqueeze.rb
@@ -0,0 +1,16 @@
+require 'formula'
+
+class Pdfsqueeze < Formula
+ homepage 'http://code.google.com/p/pdfsqueeze/'
+ url 'http://pdfsqueeze.googlecode.com/files/pdfsqueeze.tar.bz2'
@jacknagel
jacknagel added a line comment Sep 29, 2012

Need a versioned download.

@mathiasbynens
mathiasbynens added a line comment Sep 30, 2012

There is none. What do you suggest?

@jacknagel
jacknagel added a line comment Sep 30, 2012

At this point things without a versioned download aren't really acceptable for core; they would be better off in a tap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@jacknagel jacknagel commented on the diff Sep 29, 2012
Library/Formula/pdfsqueeze.rb
@@ -0,0 +1,16 @@
+require 'formula'
+
+class Pdfsqueeze < Formula
+ homepage 'http://code.google.com/p/pdfsqueeze/'
+ url 'http://pdfsqueeze.googlecode.com/files/pdfsqueeze.tar.bz2'
+ sha1 '1be85edbe44bbcc0a0a12841047904bef0eba02f'
+ version '1'
+
+ def install
+ bin.install 'pdfsqueeze'
+ end
+
+ def test
+ system 'which pdfsqueeze'
@jacknagel
jacknagel added a line comment Sep 29, 2012

Pointless test

@mathiasbynens
mathiasbynens added a line comment Sep 30, 2012

What’s a better way to test it, then? pdfsqueeze without any arguments seems to exit with a non-zero status code (1).

@adamv
adamv added a line comment Sep 30, 2012

You can always pipe --version or --help through cat to make the status code 0.

@mathiasbynens
mathiasbynens added a line comment Sep 30, 2012

pdfsqueeze doesn’t have --version or --help. Any other suggestions?

@adamv
adamv added a line comment Oct 20, 2012

Don't strictly need a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@adamv

Passing since this installs a precompiled binary.

@adamv adamv closed this Oct 20, 2012
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.