Added Python 3.3.0 to python3.rb #15199

Closed
wants to merge 1 commit into
from

Projects

None yet

5 participants

@ghost
ghost commented Sep 30, 2012

It'd be great if someone could double check that I did this correctly. It's working fine locally for me, but I'd like to make sure.

@densh
densh commented Sep 30, 2012

I'm heaving troubles having it installed without Xcode (only CLT) :

$ brew install python3
==> Downloading http://python.org/ftp/python/3.3.0/Python-3.3.0.tar.bz2
######################################################################## 100.0%
==> ./configure --prefix=/usr/local/Cellar/python3/3.3.0 --enable-ipv6 --dataroo
==> make
==> make install PYTHONAPPSDIR=/usr/local/Cellar/python3/3.3.0
/usr/bin/install -c -s ../python.exe "/usr/local/Cellar/python3/3.3.0/Frameworks/Python.framework/Versions/3.3/Resources/Python.app/Contents/MacOS/Python"
xcode-select: Error: No Xcode is selected. Use xcode-select -switch <path-to-xcode>, or see the xcode-select manpage (man xcode-select) for further information.
install: child process failed: xcrun strip - /usr/local/Cellar/python3/3.3.0/Frameworks/Python.framework/Versions/3.3/Resources/Python.app/Contents/MacOS/Python
make[1]: *** [install_Python] Error 70
make: *** [frameworkinstallapps] Error 2

Error: python3 did not build
Logs: /Users/Den/Library/Logs/Homebrew/python3/
Help: https://github.com/mxcl/homebrew/wiki/troubleshooting
      https://github.com/mxcl/homebrew/issues/15199

I'm not sure if that's OK as i've not used Python3 before this release. Python2 builds fine without Xcode.

@ghost
ghost commented Sep 30, 2012

Hmmm....I dunno. I just changed all the 3.2.x to 3.3.0 and added the correct checksum so I would've thought it would build the same as before....

@samueljohn

This err is known and is there for the 3.2 version, too (I assume).
We had this for python 2.7, too, but fixed it recently. The fix is not a one-liner though, but I plan to apply the fix to python 3.x as I did for 2.7.

So in short: python 3.2 and python 3.3 do need Xcode right now (and maybe X11, too) but we can fix this in the next days, when I get to it.

@swernerx
swernerx commented Oct 1, 2012

This should also use pip-1.2 instead of 1.1. Thanks!

 class Pip < Formula
-  url 'http://pypi.python.org/packages/source/p/pip/pip-1.1.tar.gz'
-  sha1 '3b002db66890880ee776bbe199c3d326d8fe3d6f'
+  url 'http://pypi.python.org/packages/source/p/pip/pip-1.2.tar.gz'
+  sha1 '7876f943cfbb0bbb725c2761879de2889c1fe93b'
 end
@samueljohn

1.2.1 maybe?

@swernerx
swernerx commented Oct 1, 2012

Oh, yes, right.

@ghost
ghost commented Oct 1, 2012

I should change and resubmit?

On Mon, Oct 1, 2012 at 9:08 AM, Samuel John notifications@github.comwrote:

1.2.1 maybe?


Reply to this email directly or view it on GitHubhttps://github.com/mxcl/homebrew/pull/15199#issuecomment-9033105.

@samueljohn

Yep, unless you want to wait for tomorrow, when I will apply the changes from python 2.7 formula to 3.2/3.

@ghost
ghost commented Oct 1, 2012

I can wait. That's fine.
On Oct 1, 2012 1:58 PM, "Samuel John" notifications@github.com wrote:

Yep, unless you want to wait for tomorrow, when I will apply the changes
from python 2.7 formula to 3.2/3.


Reply to this email directly or view it on GitHubhttps://github.com/mxcl/homebrew/pull/15199#issuecomment-9045177.

@ahojnnes
ahojnnes commented Oct 4, 2012

Any news here?

@samueljohn

Please have a look at #15297 and test it, if you can. Feedback welcome.

@samueljohn

@dsr Thanks for your, fast pull request after 3.3 release and sorry, that I was a bit behind with python 3.3 due to some urgent python 2.x issues. I ported the fixes from the python formula to python3 now and then did the version bump. (PR still open)

Also in awaiting 3.4 at some point in the future, I introduced a helper variable to easier hop from one to the next 3.x release.

@ghost
ghost commented Oct 4, 2012

I've never really committed and then had changes made on top of my commit. Do I need pull your changes @samueljohn ?

@samueljohn

@dsr yep, two possible ways:

  1. make a git branch then brew pull 15297 (all in the brew --prefix dir). So you can later go back to master easily.
  2. Get the direct raw url of my formula in my pull request. Like so brew install https://raw.github.com/samueljohn/homebrew/feacb1f1fd6ec64045313aa75eba8d0053fe8813/Library/Formula/python3.rb
@ghost
ghost commented Oct 4, 2012

@samueljohn Waitaminute....brew knows when you're working on a dev branch or something?

@samueljohn

@dsr not sure if I understand your question correctly.

Therefore, I describe the general background. Eventually things will get clearer:

In the brew --prefix dir, there is a hidden .git directory and this makes homebrew just an ordinary git repository. Normally you are on the master branch with the origin set to mxcl/homebrew from github. You can change that and/or add other branches or remotes (e.g. your own fork of homebrew) just like for any git repo.

When you brew update, I think, it attempts to switch back to master and then git pulls the new things in. However, that will error out, if you made changes yourself.

So, at any given time, you can git checkout -b my_new_test_branch and mess around and commit. And later switch back to git checkout master.

The brew pull <issuenumber> is a nice feature of homebrew that will apply the work of a given pull request (issue) onto the current branch in the form of a patch. So you'll have to undo it or switch to a new branch brefore.
Undoing is most often as easy as git reset --hard origin/master.

The other (perhaps simpler) method to test a certain pull request is to install from the url directly.

Hope this helps.

@ghost
ghost commented Oct 5, 2012

@samueljohn Definitely helps. Thanks for taking the time to elaborate.

@ghost ghost closed this Oct 7, 2012
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.