tinyca2 #15219

Closed
wants to merge 1 commit into
from

5 participants

@nupfel

installs TinyCA 2, nothing special

@jacknagel jacknagel commented on an outdated diff Oct 1, 2012
Library/Formula/tinyca2.rb
@@ -0,0 +1,34 @@
+require 'formula'
+
+# Documentation: https://github.com/mxcl/homebrew/wiki/Formula-Cookbook
+# PLEASE REMOVE ALL GENERATED COMMENTS BEFORE SUBMITTING YOUR PULL REQUEST!
@jacknagel
jacknagel added a line comment Oct 1, 2012

Do this

@jacknagel
jacknagel added a line comment Oct 1, 2012

Also indents should be 2sp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@nupfel

sorry about that!
it's my first one.
fixed the comments and added a test

@mistydemeo

This doesn't work for me:

Can't locate Gtk2.pm in @INC (@INC contains: /usr/local/Cellar/tinyca2/0.7.5/lib /Library/Perl/Updates/5.10.0/darwin-thread-multi-2level /Library/Perl/Updates/5.10.0 /System/Library/Perl/5.10.0/darwin-thread-multi-2level /System/Library/Perl/5.10.0 /Library/Perl/5.10.0/darwin-thread-multi-2level /Library/Perl/5.10.0 /Network/Library/Perl/5.10.0/darwin-thread-multi-2level /Network/Library/Perl/5.10.0 /Network/Library/Perl /System/Library/Perl/Extras/5.10.0/darwin-thread-multi-2level /System/Library/Perl/Extras/5.10.0 .) at /usr/local/bin/tinyca2 line 26.

Is there an extra dependency for this? If it's the "gtk2" module from cpan, you can declare it by adding:

depends_on 'gtk2' => :perl

@nupfel

indeed! you are right.
it should do now.
tinyca2 is really not the best piece of code :)

@adamv

Please squash to a single commit for review.

@nupfel

done

@nupfel

anything still missing here?

@adamv

CPAN gives me: Warning: Cannot install gtk2, don't know what it is.

@mistydemeo

Apparently cpan is case sensitive. cpan -i Gtk2 works.

@mistydemeo

So I guess the dependency should be depends_on 'Gtk2' => :perl

@nupfel

here we go again :)

@adamv adamv was assigned Oct 8, 2012
@nupfel

anyone going to have a look at this or what?

@MikeMcQuaid
Homebrew member

Please be patient, we've got lots of issues and all have jobs. We'll get to you as soon as possible.

@mxcl
Homebrew member

We should add to the contributing file that if you require a merge urgently for other people, note that others can easily merge your homebrew fork in the meantime.

@mistydemeo

The class name here is incorrect (did that change from the old version?). Homebrew finds the class based on the filename, so in tinyca2.rb it looks for a class named Tinyca2. (Capital letters make Homebrew look for a hyphen - so TinyCA2 translates to a formula named tiny-c-a2.rb)

Tobias Kirschstein new formula 'tinyca2'
installs TinyCA 2, nothing special
removed comments added a test
the test is a simple perl compile test
added gtk2 perl dependecy
used interpolation syntax for test, cheers to adam
fixed Gtk2 perl dependency
38cbc33
@nupfel

sorry, will be more patient next time. there were so many quick responses in the beginning :)
hmm, the class name. i somehow thought it has to match the actual project name as it's advertised. changed it back.

@mistydemeo

I would probably be more able to test this if I could actually get the Gtk2 perl module to install, argh. It seems to be hanging forever running tests on one of its dependencies.

@adamv

Maybe have to code a custom requirement instead of using the built-in perl support.

@mistydemeo

@adamv Not really sure that would help in this case, since it doesn't build without the module. Either way it can't be installed without.

@nupfel

what's the status? i got the gtk2 perl module installed just fine using cpanm

@nupfel

knock knock

@mistydemeo

I still can't get the perl deps to install without forcing them, due to many failing tests. @adamv Does it work for you?

(Incidentally: it looks like there's a runtime dep on the gettext perl module.)

@adamv

I suggest adding explicit cpan steps to def caveats.

@adamv
Checking if your kit is complete...
Looks good
MakeMaker FATAL: prerequisites not found.
    ExtUtils::Depends not installed
    ExtUtils::PkgConfig not installed
    Glib not installed
    Pango not installed

Please install these modules first and rerun 'perl Makefile.PL'.
Warning: No success on command[/usr/bin/perl Makefile.PL]
  XAOC/Gtk2-1.247.tar.gz
  /usr/bin/perl Makefile.PL -- NOT OK
Running make test
  Make had some problems, won't test
Running make install
  Make had some problems, won't install

The Gtk2 perl module requires gtk2 stuff to be installed first; so this formula needs to depend on those too, though it's kind of hard to model this dependency chain right now.

@nupfel

shouldn't this rather be the responsibility of the Gtk2 module maintainer?
i'll have a look at the macports port and try to copy that one

@adamv

Maintainers, I'm -1 on this and want to suggest an external tap due to the age and lack of progress; unless someone else wants to take a crack at getting this brewing?

@MikeMcQuaid
Homebrew member

@adamv Seems fair.

@adamv

Passing on this, sorry.

@adamv adamv closed this May 12, 2013
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.