crossroads: fix pgm build errors #15255

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@2bits

crossroads builds an internal libpgm from source, but that causes
build errors because of a conflicting struct definition with OSX
netinet.h. So instead of dealing with that, link crossroads
against our libpgm-5.2 which builds without error. Add a couple
of ENV vars to override pkg-config and help crossroads find
the libpgm we now depend on, which it can't find otherwise because
it's looking for openpgm-5.1.pc and we offer openpgm-5.2.pc.
Crossroads passes make check on 10.8.2 with XCode-4.5.

Fixes #15217

@2bits 2bits crossroads: fix pgm build errors
crossroads builds an internal libpgm from source, but that causes
build errors because of a conflicting struct definition with OSX
`netinet.h`.  So instead of dealing with that, link crossroads
against our libpgm-5.2 which builds without error.  Add a couple
of ENV vars to override `pkg-config` and help crossroads find
the libpgm we now depend on, which it can't find otherwise because
it's looking for `openpgm-5.1.pc` and we offer `openpgm-5.2.pc`.
Crossroads passes `make check` on 10.8.2 with XCode-4.5.

Fixes #15217
b0949c7
@adamv adamv added a commit that closed this pull request Oct 2, 2012
@2bits 2bits crossroads: fix pgm build errors
crossroads builds an internal libpgm from source, but that causes
build errors because of a conflicting struct definition with OSX
`netinet.h`.  So instead of dealing with that, link crossroads
against our libpgm-5.2 which builds without error.  Add a couple
of ENV vars to override `pkg-config` and help crossroads find
the libpgm we now depend on, which it can't find otherwise because
it's looking for `openpgm-5.1.pc` and we offer `openpgm-5.2.pc`.
Crossroads passes `make check` on 10.8.2 with XCode-4.5.

Fixes #15217

Closes #15255.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
47cfcad
@adamv adamv closed this in 47cfcad Oct 2, 2012
@snakeyroc3 snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012
@2bits 2bits crossroads: fix pgm build errors
crossroads builds an internal libpgm from source, but that causes
build errors because of a conflicting struct definition with OSX
`netinet.h`.  So instead of dealing with that, link crossroads
against our libpgm-5.2 which builds without error.  Add a couple
of ENV vars to override `pkg-config` and help crossroads find
the libpgm we now depend on, which it can't find otherwise because
it's looking for `openpgm-5.1.pc` and we offer `openpgm-5.2.pc`.
Crossroads passes `make check` on 10.8.2 with XCode-4.5.

Fixes #15217

Closes #15255.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
6305618
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.