This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
crossroads: fix pgm build errors #15255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crossroads builds an internal libpgm from source, but that causes build errors because of a conflicting struct definition with OSX `netinet.h`. So instead of dealing with that, link crossroads against our libpgm-5.2 which builds without error. Add a couple of ENV vars to override `pkg-config` and help crossroads find the libpgm we now depend on, which it can't find otherwise because it's looking for `openpgm-5.1.pc` and we offer `openpgm-5.2.pc`. Crossroads passes `make check` on 10.8.2 with XCode-4.5. Fixes Homebrew#15217
snakeyroc3
pushed a commit
to snakeyroc3/homebrew
that referenced
this pull request
Dec 17, 2012
crossroads builds an internal libpgm from source, but that causes build errors because of a conflicting struct definition with OSX `netinet.h`. So instead of dealing with that, link crossroads against our libpgm-5.2 which builds without error. Add a couple of ENV vars to override `pkg-config` and help crossroads find the libpgm we now depend on, which it can't find otherwise because it's looking for `openpgm-5.1.pc` and we offer `openpgm-5.2.pc`. Crossroads passes `make check` on 10.8.2 with XCode-4.5. Fixes Homebrew#15217 Closes Homebrew#15255. Signed-off-by: Adam Vandenberg <flangy@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crossroads builds an internal libpgm from source, but that causes
build errors because of a conflicting struct definition with OSX
netinet.h. So instead of dealing with that, link crossroadsagainst our libpgm-5.2 which builds without error. Add a couple
of ENV vars to override
pkg-configand help crossroads findthe libpgm we now depend on, which it can't find otherwise because
it's looking for
openpgm-5.1.pcand we offeropenpgm-5.2.pc.Crossroads passes
make checkon 10.8.2 with XCode-4.5.Fixes #15217