Add formula: xmlsh (1.2.1) #15339

Closed
wants to merge 3 commits into
from

Projects

None yet

3 participants

@Zearin
Zearin commented Oct 7, 2012

NOTE: This is an update to Homebrew/legacy-homebrew#13324

Cleaned up formula and updated to the latest version.

Zearin Update xmlsh to `1.2.0` (and formula tweaks)
Formula now deletes Win32 and cygwin files during installation.
369229d
@adamv

Don't need self before libexec

@adamv

We generally don't reference XDG paths

Also, for completeness, there are a few things wrong with this line, if I'm reading your intentions correctly.

The construct "variable = val || other_val" doesn't exist in that form in shell script.

What you want is probably something along the lines of

: ${XDG_CONFIG_HOME:=$HOME}
test -n "$XDG_CONFIG_HOME" || exit 1

note that anything in parens is executed in a subshell, so exiting in that subshell will not exit the parent script early. You can see this with this simple example:

#!/bin/sh
(exit 1)
echo "foo"
@adamv

blank line in script file

@adamv

Fix or remove TODO

@adamv

Need to be "#{bin}/xmlsh"

Zearin added some commits Oct 7, 2012
Zearin Add formula for `xmlsh` (1.2.1)
**NOTE:**
This supersedes mxcl/issues/13324

Added formula for `xmlsh`, the XML Shell.

Signed-off-by: Zearin <zearin@gonk.net>
ed17951
Zearin Merge branch 'master' of https://github.com/Zearin/homebrew
Conflicts:
	Library/Formula/xmlsh.rb

Signed-off-by: Zearin <zearin@gonk.net>
ace6671
@adamv
adamv commented Oct 7, 2012

Please squash to a single commit for review, thanks.

@adamv

This test seems to leave the user in an interactive shell; not allowed for a test script.

Hmm. That’s definitely not supposed to happen.

I’ll check it out.

@adamv adamv added a commit that closed this pull request Jan 14, 2013
Zearin xmlsh 1.2.1
Closes #15339.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
1c65885
@adamv adamv closed this in 1c65885 Jan 14, 2013
@dholm dholm added a commit to dholm/homebrew that referenced this pull request Jan 14, 2013
Zearin xmlsh 1.2.1
Closes #15339.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
64da2c2
@norioxkimura norioxkimura added a commit to norioxkimura/homebrew that referenced this pull request Jan 16, 2013
Zearin xmlsh 1.2.1
Closes #15339.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
606e918
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.