This repository has been archived by the owner. It is now read-only.

New Formula: gdmap 0.8.1 #15432

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

ScottAlbertine commented Oct 12, 2012

Add the formula for installing gdmap, a disk mapping utility using Gnome
for display. The formula has minor patches to the sourcecode to account
for Mac/Linux differences.

Contributor

adamv commented Oct 24, 2012

Ping

Contributor

mistydemeo commented Oct 24, 2012

Upstream is not active. The last release, and last commit in their cvs, was 4 years ago.

Contributor

adamv commented Oct 24, 2012

Ok; I'll pull this, but if it gets to be a maintenance problem we'll probably drop it again (unless someone starts maintaining it.)

Contributor

mistydemeo commented Oct 24, 2012

@adamv Don't pull yet. @ScottAlbertine was on IRC earlier having trouble getting it working with the current version of cairo. I believe it's currently broken.

Contributor

adamv commented Oct 24, 2012

Ok

Contributor

ScottAlbertine commented Oct 25, 2012

Apparently, it was only incompatible with Cario 1.12.4 Having updated to Cairo 1.12.6 it works totally fine, with no changes to the ruby script or code. Please consider this back on the menu for pulling again :D

Contributor

ScottAlbertine commented Oct 30, 2012

@adamv ping

Contributor

adamv commented Oct 30, 2012

Someone pull this, thanks.

Library/Formula/gdmap.rb
+ def install
+ system "./configure", "--disable-debug", "--disable-dependency-tracking",
+ "--prefix=#{prefix}",
+ "LIBS=-lxml2 -lintl -lglib-2.0 -lgtk-x11-2.0 -lgdk-x11-2.0 -lgdk_pixbuf-2.0 -lgobject-2.0"
@jacknagel

jacknagel Oct 30, 2012

Contributor

Is this line strictly necessary? pkg-config normally handles this, and it did when I tested it.

Library/Formula/gdmap.rb
+ end
+
+ def test
+ system "gdmap"
@jacknagel

jacknagel Oct 30, 2012

Contributor

#{bin}/gdmap

Contributor

ScottAlbertine commented Oct 31, 2012

@jacknagel fixed

@ghost ghost assigned adamv Oct 31, 2012

Contributor

adamv commented Oct 31, 2012

Is the full :x11 dep appropriate here? Looks like it tries to link against freetype specifically.

Contributor

adamv commented Oct 31, 2012

Failure to launch:

$ gdmap
** Message: No such file or directory
Assertion failed: (_cairo_status_is_error (status)), function _cairo_error, file cairo-error.c, line 68.
Abort trap: 6
Contributor

ScottAlbertine commented Oct 31, 2012

@adamv the whole program displays in an X11 window, so I think the X11 dep is appropriate. Also, I got that error when I upgraded cairo myself, doing some combination of brew cleanup -s, removing the old version of cairo, reinstalling cairo, and reinstalling gdmap fixed it for me. Not sure which step was the one that fixed it, and there was no change in the ruby script for gdmap to get it working again though, so I don't know how to fix it in the forumla.

Contributor

jacknagel commented Oct 31, 2012

Also as long as it has a dep on gtk+ it has a transient dep on x11 anyway.

ScottAlbertine added some commits Oct 12, 2012

Add formula for gdmap
Add the formula for installing gdmap, a disk mapping utility using Gnome
for display.  The formula has minor patches to the sourcecode to account
for Mac/Linux differences.
Cleaned up based on jacknagel's comments
Removed unnecessary LIBS inclusion line and used #{bin} in the test.
Remove direct X11 dependency
X11 dependency is implied by gtk+ dependency
Contributor

ScottAlbertine commented Nov 6, 2012

@jacknagel @adamv x11 dep removed

Contributor

ScottAlbertine commented Nov 26, 2012

@adamv is your failure to launch issue still outstanding? If not, can this be pulled in?

@adamv adamv closed this in 7f630c1 Jan 4, 2013

dholm added a commit to dholm/homebrew that referenced this pull request Jan 14, 2013

gdmap 0.8.1
Closes #15432.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.