This repository has been archived by the owner. It is now read-only.

povray 3.7.0.RC6 squashed #15576

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
7 participants
Contributor

royhodgman commented Oct 21, 2012

Note: this pull request is a squashed version of the commits in issue #15093.

The previous version of povray (3.6.1) would not compile with recent versions of libpng. This beta version does compile with recent versions of libpng.

Almost all changes to this formula come from studying the povray portfile from MacPorts and reading a bug report about how they solved the same problem.

Note: povray now requires at least Lion to compile.

povray 3.7.0.RC6
The previous version of povray (3.6.1) would not compile with recent versions of libpng. This beta version does compile with recent versions of libpng.

Almost all changes to this formula come from studying the [povray portfile][1] from MacPorts and reading [a bug report][2] about how they solved the same problem.

Note: povray now requires at least Lion to compile.

[1]: https://svn.macports.org/repository/macports/trunk/dports/graphics/povray/Portfile "MacPorts POV-Ray portfile"
[2]: https://trac.macports.org/ticket/35949 "MacPorts Ticket 35949"

@royhodgman royhodgman referenced this pull request Oct 21, 2012

Closed

povray 3.7.0.RC6 #15093

Contributor

adamv commented Oct 21, 2012

Assuming the original pull request was made from a non-master branch, you can git push -f to update it in place.

Contributor

adamv commented Oct 21, 2012

Note to other maintainers: I'm OK pulling this as Lion-only, as long as 3.6.1 goes into versions and is mentioned in the caveats/Lion requirement message.

Contributor

mistydemeo commented Oct 21, 2012

What I'm curious about is...

The previous version of povray (3.6.1) would not compile with recent versions of libpng.

The current version of the formula is using its builtin version of libpng, and shouldn't be trying to link against the system or Homebrew version. Are you still unable to build 3.6.1 on Lion/Mtn Lion?

Contributor

royhodgman commented Oct 23, 2012

@adamv I'll create a pull request for 3.6.1 to be added to versions. Accordingly, I'll update this formula with a message as you suggest. Should I go back to the original pull request and do that there (and squash everything in place), or would you rather have that here?

Contributor

royhodgman commented Oct 23, 2012

@mistydemeo I tried to build 3.6.1 on mtn lion and ran into the same errors reported in the macports bug report listed above. Once I got it to build I didn't investigate about how to make the build work with povray's built in version of libpng.

Is there a workaround at the moment? B/c I'm having the same problems (I think) installing povray on Mountain Lion.

Contributor

adamv commented Jan 13, 2013

MacPorts packages this version, and it compiles on pretty much all platforms MacPorts supports: https://trac.macports.org/browser/trunk/dports/graphics/povray/Portfile

So, we should clean up this request and merge this.

@ghost ghost assigned adamv Jan 13, 2013

Contributor

boyanpenkov commented Jan 30, 2013

I came across this when trying to install POVRay this morning; what can do to help close this?

Contributor

adamv commented Jan 31, 2013

@boyanpenkov brew pull 15576 then brew install povray then tell us if it works or crashes

Contributor

adamv commented Jan 31, 2013

Tested OK on a Lion box; will test on Snow Leopard.

Contributor

boyanpenkov commented Jan 31, 2013

Yes, this does work, and yields 3.7.0.RC6, with vociferous warnings about it being RC and not final.

I'm on Mountain Lion, with the latest homebrew.

Thanks!

Boyan Penkov

On Jan 31, 2013, at 12:34 AM, Adam Vandenberg notifications@github.com wrote:

@boyanpenkov brew pull 15576 then brew install povray then tell us if it works or crashes


Reply to this email directly or view it on GitHub.

Contributor

mistydemeo commented Jan 31, 2013

Macports doesn't build it on Snow Leopard yet, but this bug report does have a patch which was suggested on the povray forums: https://trac.macports.org/ticket/36940

No idea what the official word is here or whether this is safe, etc. It does build and pass tests for me with it.

Owner

MikeMcQuaid commented Feb 1, 2013

@adamv Want to add?

Contributor

adamv commented Feb 1, 2013

Didn't compile on Snow Leopard for me

Owner

MikeMcQuaid commented Feb 1, 2013

@adamv Let's either make it Lion-only or close.

Contributor

adamv commented Feb 1, 2013

I'll make it Lion-only and move 3.6 to versions and suggest that for Snow Leopard users.

Contributor

mistydemeo commented Feb 1, 2013

@adamv Did you try the patch from the issue I linked? It builds and passes tests on Snow Leopard with that. (Though like I say, I have no idea how "okay" that patch is.)

@adamv adamv closed this in fba70bb Feb 1, 2013

Contributor

cdlm commented Feb 2, 2013

Still failing on Mountain Lion (10.8.2) now apparently due to boost:

...
c++  -pipe -Wno-multichar -Wno-write-strings -O3 -ffast-math -march=native -D_THREAD_SAFE   -o povray disp_sdl.o disp_text.o ../vfe/libvfe.a ../source/backend/libbackend.a ../source/frontend/libfrontend.a ../source/base/libbase.a ../source/libpovray.a -lIlmImf -L/opt/homebrew/Cellar/openexr/1.7.0/lib -L/opt/homebrew/Cellar/ilmbase/1.0.2/lib -lIlmImf -lz -lImath -lHalf -lIex -lIlmThread   -lIlmThread -ltiff -ljpeg -lpng -lz -lm  -lboost_system-mt -D_THREAD_SAFE
brew: superenv removed: -Wno-multichar -Wno-write-strings -O3 -march=native
Undefined symbols for architecture x86_64:
  "boost::this_thread::interruption_point()", referenced from:
      void boost::condition_variable_any::wait<boost::unique_lock<boost::mutex> >(boost::unique_lock<boost::mutex>&) in libvfe.a(vfesession.o)
...
Contributor

royhodgman commented Feb 2, 2013

It builds fine for me on 10.8.1 and xcode 4.5, so I'm updating both and will try again.

Contributor

royhodgman commented Feb 2, 2013

And now it compiles and renders test scenes fine for me on 10.8.2 and xcode 4.6.

I ran:

brew remove povray
brew remove boost
brew install povray

and didn't see any errors.

@cdlm Which version of boost are you linking against?

Contributor

cdlm commented Feb 3, 2013

boost 1.52.0 (freshly built as a dependency of povray), xcode 4.6… now trying a second build after removing both as you suggest…

(edit, later) …and here's the end of the build log: https://gist.github.com/4700003

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.