This repository has been archived by the owner. It is now read-only.

Update percona-server to use mysql data & share directory if no previous percona data directory exists. #15921

Merged
0 commits merged into from Nov 14, 2012

Conversation

Projects
None yet
1 participant
@ghost

ghost commented Nov 8, 2012

Code for mxcl#15901.

@ghost

ghost commented Nov 8, 2012

Updated. mysql_install_db creates "#{var}/#{destination}" and for some reason didn't work as (var/destination).mkpath anyway.

Library/Formula/percona-server.rb
@@ -113,9 +117,6 @@ def caveats; <<-EOS.undent
Note: if this fails, you probably forgot to run the first two steps up above
- A "/etc/my.cnf" from another install may interfere with a Homebrew-built
- server starting up correctly.
-
@jacknagel

jacknagel Nov 14, 2012

Contributor

Reason for removing this?

@ghost

ghost Nov 14, 2012

I copied that from original pull-request, didn't give a specific though to it ? do you want it back ?

Library/Formula/percona-server.rb
# Fix up the control script and link into bin
inreplace "#{prefix}/support-files/mysql.server" do |s|
s.gsub!(/^(PATH=".*)(")/, "\\1:#{HOMEBREW_PREFIX}/bin\\2")
end
+
@jacknagel

jacknagel Nov 14, 2012

Contributor

Please avoid unrelated whitespace changes.

@ghost

ghost commented Nov 14, 2012

@jacknagel Updated.

@ghost

ghost commented Nov 14, 2012

If you agree with this: mxcl#16055 I can remove that line here.

Library/Formula/percona-server.rb
def install
# Build without compiler or CPU specific optimization flags to facilitate
# compilation of gems and other software that queries `mysql-config`.
ENV.minimal_optimization
- # Make sure the var/msql directory exists
- (var+"percona").mkpath
-
@jacknagel

jacknagel Nov 14, 2012

Contributor

I'm curious why, as you noted, this doesn't work as (var/destination).mkpath. Presumably it made its way into the mysql family of formulae for a reason.

@ghost

ghost Nov 14, 2012

It works! I must have screwed something when I was testing it. GitHub closed PR when I pushed empty branch with FD. I have added it back.

@ghost

ghost Nov 14, 2012

Oh yes, I remember what was wrong, I was looking for percona folder, which I was deleting, but it would never create percona folder, it only can create mysql directory. Do I need to open new RP ?

@ghost ghost merged commit 66682e5 into Homebrew:master Nov 14, 2012

Contributor

jacknagel commented Nov 14, 2012

I can't reopen this, so you can just submit a new PR.

@ghost

ghost commented Nov 14, 2012

Should I also remove std_cmake_args as in mxcl#16055 ?

@ghost ghost referenced this pull request Nov 14, 2012

Closed

percona-server fixes #16070

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.