This repository has been archived by the owner. It is now read-only.

Give a fresh beer after the hard work of brewing #16020

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
Contributor

samueljohn commented Nov 13, 2012

This is a little visual tuning and a bit of fun, too.

At the beginning of the summary line a 🍺 is given out (but only on Mountain Lion or above). This acts as a nice visual marker for the end of a (successful) brew-ing process. Helpful, especially when several deps are being brewed. It's also a little bit of branding for Homebrew.

  • Name of the brewed formula in "Summary" heading. It was so hard to quickly scan for the name in homebrew/Cellar/sqlite/3.7.14.1: 9 files, 1,9M, built in 23 seconds
  • Name of the currently brewing formula (or dep) is in green. That makes is possible to scan for the formula names effortlessly. See shots below.

Tested with Terminal.app and all kind of different fonts. Please test with iTerm and what-so-ever your favorite term is.

sample
...snip...
sample
...snip...
sample

Contributor

samueljohn commented Nov 13, 2012

@humdedum well first, I'd like to get some feed-back and second, let's see how far we can get with unicode :-)

Right now, it's not optional. Worst thing that can happen is you see the unicode sequence <U+1F37A> instead of a 🍺.

Owner

MikeMcQuaid commented Nov 13, 2012

This is amazing

@ghost

ghost commented Nov 13, 2012

😱 😱 😱 😱 😱 😱 😱 😱 😱

Contributor

MindTooth commented Nov 13, 2012

iTerm 2, Adobe Source Code Pro, base16 theme.

Beer Console

Contributor

bjoernalbers commented Nov 13, 2012

awesome!

Contributor

asparagui commented Nov 13, 2012

👍 🍺

Member

mxcl commented Nov 13, 2012

Hah. I am 80% in love.

Bit tacky maybe? @jacknagel, @adamv, @mistydemeo, @Sharpie.

Contributor

adamv commented Nov 13, 2012

Fine by me.

Contributor

Sharpie commented Nov 13, 2012

What's the point of having a beer theme if we don't use it? +1 here.

Contributor

samueljohn commented Nov 13, 2012

@humdedum That is syntax highlighting of the zsh (I use zprezto (search on github)).
@MindTooth thanks for the iTerm check!
@mxc for the missing 20%, there is an emoji with two beer jugs for brew2 ;-P

Oh, I haven't tested ssh yet.

Contributor

mistydemeo commented Nov 14, 2012

👍

Works just fine for me in Lion, btw:

Contributor

samueljohn commented Nov 14, 2012

@mistydemeo shall I replace the guard MacOS.version >= :mountain_lion by MacOS.version >= :lion, then?
I'd expect you don't get a beer with your Lion.

Contributor

bjoernalbers commented Nov 14, 2012

@mxcl 80% are enough (Pareto)

Just let me know when the official t-shirts are ready to order...

Contributor

mistydemeo commented Nov 14, 2012

@samueljohn Yeah, I tested by changing the guard. The emoji is in Lion so totally should be enabled there.

Contributor

samueljohn commented Nov 14, 2012

@mistydemeo Ok, fixed. Now the Lion gets drunk, too.

Contributor

samueljohn commented Nov 22, 2012

Let me know, if there is anything holding you back.

/offtopic: "Adobe Source Code Pro" looks fantastic, @MindTooth. I switched.

Contributor

samueljohn commented Dec 17, 2012

We won't get moar_beer until someone pulls it :-)

@samueljohn samueljohn Give a fresh 🍺 after hard work of brew install
- Name of the brewed formula in "Summary" heading.
- At the beginning of the summary line a 🍺  is given out
  (but only on Lion or above). This acts as a nice
  visual marker for the end of a brew-ing process.
- When brewing a dependency, the name is highlighted in green.
- `oh1` is bold, too (like ohai).
6e3758d
Contributor

samueljohn commented Jan 11, 2013

🎵

Owner

MikeMcQuaid commented Jan 11, 2013

You think just because I'm in a good mood I'll pull this? You are right. We can always revert if it breaks the universe.

Contributor

samueljohn commented Jan 11, 2013

Harhar! Now I am going to re-brew everything just to see the beer coming in!

Quite some people have tested this now ... but you never know ... let's see.

@samueljohn samueljohn deleted the samueljohn:moar_beer branch Jan 11, 2013

Contributor

samueljohn commented Jan 11, 2013

Now that I see it

🍺 /usr/local/Cellar/python/2.7.3: 5169 files, 79M, built in 87 seconds

I wish I had replaces "built" by "brewed" ...

Owner

MikeMcQuaid commented Jan 11, 2013

I'm up for that. @mxcl ?

Contributor

justinkb commented Jan 11, 2013

shows a white background pic on a dark background for me. iterm2/solarized colors.

can I just revert 21617a7 to disable this or is it more involved?

Owner

MikeMcQuaid commented Jan 11, 2013

Screenshot please?

Contributor

adamv commented Jan 11, 2013

It's a beer in a white square on a black terminal background, I see it too. Use your imagination.

Contributor

samueljohn commented Jan 11, 2013

On Mountain Lion it shows correctly with transparency around the 🍺
@justinkb are you on Lion?

We can deactivate it on Lion as in the initial revision.

Contributor

samueljohn commented Jan 11, 2013

On 10.8 transparency works (Terminal.app) on a bright background.

Screen Shot 2013-01-11 at 18 53 47

Contributor

samueljohn commented Jan 11, 2013

print "🍺 " if MacOS.version >= :lion

should be :mountain_lion then if :lion user see it ugly. @justinkb drag'n'drop a shot!

Contributor

justinkb commented Jan 11, 2013

sorry to burst your bubble, but I'm on mountain lion ;-) I guess the difference is that you use Terminal.app and I use iTerm.app? TERM_PROGRAM env variable could be used here, set to Apple_Terminal for Terminal.app, iTerm.app for iTerm.

Screen Shot 2013-01-11 at 7 13 59 PM

Contributor

MindTooth commented Jan 11, 2013

Can confirm with iTerm:

Maybe it's a bug related to how iTerm renders stuff?

Contributor

dcoeurjo commented Jan 11, 2013

A bit out-of-topic, sorry for that but @justinkb, how have you setup this neat prompt in your iTerm?

@Sharpie Sharpie pushed a commit to Sharpie/homebrew that referenced this pull request Jan 11, 2013

@samueljohn @MikeMcQuaid samueljohn + MikeMcQuaid Give a fresh 🍺 after hard work of brew install
- Name of the brewed formula in "Summary" heading.
- At the beginning of the summary line a 🍺  is given out
  (but only on Lion or above). This acts as a nice
  visual marker for the end of a brew-ing process.
- When brewing a dependency, the name is highlighted in green.
- `oh1` is bold, too (like ohai).

Closes #16020.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
f0d2b6e
Contributor

samueljohn commented Jan 11, 2013

in iTerm2 (just downloaded) it looks good on the default black bg. How do I set up a bright bg?

Contributor

samueljohn commented Jan 11, 2013

Found bright bg and transparency. But looks good still. Do you use an old iTerm?
Screen Shot 2013-01-11 at 20 31 03

Contributor

dcoeurjo commented Jan 12, 2013

@MindTooth @justinkb thanks ! The complete combo is: zsh/"oh my zsh"/"agnoster" theme/iTerm2

By the way, the beer symbol is fine in my setting.

Contributor

samueljohn commented Jan 12, 2013

Instead of "oh my zsh", I recommend zprezto.

I tested @MindTooth's theme suggestion, but works perfectly well in 10.8 with iTerm2.

Contributor

MindTooth commented Jan 12, 2013

I ran a self-compiled build. With the dec. 24 release, it works just fine :)

Contributor

samueljohn commented Jan 12, 2013

@MindTooth I tried with your link to base16-eighties.dark.256.itermcolors, imported that into iTerm2, but still, it looks flawless (without a rectangle). Even tried to add a background image or whatever. I can't break it.

Contributor

MindTooth commented Jan 12, 2013

Sorry. I didn't elaborate enough. I download the latest release from iTerm2. And it do work for me :)

Doesn't work here either, latest Mountain Lion, latest iTerm2. I'm happy to share my iTerm settings and colors in case you want to debug.

Edit: wow, pretty weird. I copy&pasted the emoji into my Terminal, then aborted the command with Ctrl+C. This results in the first, previously broken, occurrence of the emoji being shown properly, without white background. This is reproducable for me, i.e. repeating the copy&paste and Ctrl+C results in the next occurrence being shown correctly.

Contributor

samueljohn commented Jan 13, 2013

Ensure you have UTF-8 encoding (which is the default for iTerm and Terminal)

Contributor

samueljohn commented Jan 13, 2013

Please send me your config to github@samueljohn.de @matrixagent

Contributor

yrammos commented Jan 14, 2013

If I submit a pull request enabling a --brewcoffee option, does it stand any chance?

Contributor

amarshall commented Jan 14, 2013

This iTerm issue suggests the unicode emoji background color problem is fixed in trunk, but not in a released version yet.

@dholm dholm added a commit to dholm/homebrew that referenced this pull request Jan 14, 2013

@samueljohn @dholm samueljohn + dholm Give a fresh 🍺 after hard work of brew install
- Name of the brewed formula in "Summary" heading.
- At the beginning of the summary line a 🍺  is given out
  (but only on Lion or above). This acts as a nice
  visual marker for the end of a brew-ing process.
- When brewing a dependency, the name is highlighted in green.
- `oh1` is bold, too (like ohai).

Closes #16020.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
9720e6f

@norioxkimura norioxkimura added a commit to norioxkimura/homebrew that referenced this pull request Jan 16, 2013

@samueljohn @norioxkimura samueljohn + norioxkimura Give a fresh 🍺 after hard work of brew install
- Name of the brewed formula in "Summary" heading.
- At the beginning of the summary line a 🍺  is given out
  (but only on Lion or above). This acts as a nice
  visual marker for the end of a brew-ing process.
- When brewing a dependency, the name is highlighted in green.
- `oh1` is bold, too (like ohai).

Closes #16020.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
958ea23
Contributor

FredericJacobs commented Jan 16, 2013

Thanks guys, this made my day 👍
Screen Shot 2013-01-16 at 6 30 55 PM

Contributor

justinkb commented Jan 17, 2013

building iTerm from the latest git revision indeed fixed this.

No offense, is it possible to disable the emojis (not a fan of emojis)?

Contributor

samueljohn commented Jan 23, 2013

export HOMEBREW_NO_EMOJI=1 it's in the wiki.

@samueljohn: wonderful, thanks!

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.