Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Revert share directory change, remove std_cmake_args. #16055
Share directory change in f7eaa7c caused issues, for example mysql_install_db exited with an error:
FATAL ERROR: Could not find errmsg.sys
The following directories were searched:
I made the change because I thought Percona Server uses /usr/local/share as share directory, not its own directory under opt. In this case using /percona is not needed.
I also removed std_cmake_args, because for example it adds -DCMAKE_BUILD_TYPE=None which is later overwritten anyway with -DCMAKE_BUILD_TYPE=RelWithDebInfo, so it doesn't make too much sense. Neither mysql nor mariadb uses std_cmake_args.
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
/usr/local/opt is a separate directory structure. Things still get linked into /usr/local/share as before. I see both the mysql and mariadb formulae specify share/name for this.
Ok, found the cause. This line is in mysql_install_db:
It looks for the language files in share/english and share/mysql/english, that's why it can't find them in share/percona/english. Shall I make an other pull request which changes