Revert share directory change, remove std_cmake_args. #16055

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

gergoerdosi commented Nov 14, 2012

Share directory change in f7eaa7c caused issues, for example mysql_install_db exited with an error:

FATAL ERROR: Could not find errmsg.sys

The following directories were searched:

/usr/local/opt/percona-server/share/english
/usr/local/opt/percona-server/share/mysql/english

I made the change because I thought Percona Server uses /usr/local/share as share directory, not its own directory under opt. In this case using /percona is not needed.

I also removed std_cmake_args, because for example it adds -DCMAKE_BUILD_TYPE=None which is later overwritten anyway with -DCMAKE_BUILD_TYPE=RelWithDebInfo, so it doesn't make too much sense. Neither mysql nor mariadb uses std_cmake_args.

Contributor

jacknagel commented Nov 14, 2012

I made the change because I thought Percona Server uses /usr/local/share as share directory, not its own directory under opt. In this case using /percona is not needed.

/usr/local/opt is a separate directory structure. Things still get linked into /usr/local/share as before. I see both the mysql and mariadb formulae specify share/name for this.

Contributor

gergoerdosi commented Nov 14, 2012

I see, haven't known about symlinks. They are indeed wrong, /percona is needed. I'll try to figure out why mysql_install_db gives that error in this case.

Contributor

gergoerdosi commented Nov 14, 2012

Ok, found the cause. This line is in mysql_install_db:

langdir=`find_in_basedir --dir errmsg.sys share/english share/mysql/english`

It looks for the language files in share/english and share/mysql/english, that's why it can't find them in share/percona/english. Shall I make an other pull request which changes "-DINSTALL_MYSQLSHAREDIR=#{share.basename}/percona", to "-DINSTALL_MYSQLSHAREDIR=#{share.basename}/mysql", ?

Unknown referenced this pull request Nov 14, 2012

Closed

percona-server fixes #16070

Contributor

jacknagel commented Nov 15, 2012

Addressed by #16070.

jacknagel closed this Nov 15, 2012

xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.