This repository has been archived by the owner. It is now read-only.

added 'normalize' formula #16101

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@bwagner
Contributor

bwagner commented Nov 16, 2012

No description provided.

@mistydemeo

View changes

Show outdated Hide outdated Library/Formula/normalize.rb Outdated
@mistydemeo

View changes

Show outdated Hide outdated Library/Formula/normalize.rb Outdated
@mistydemeo

This comment has been minimized.

Show comment
Hide comment
@mistydemeo

mistydemeo Nov 20, 2012

Contributor

When I built normalize, it picked up mad and linked against it. Looks like it's an optional dependency. Maybe it should be marked as a dependency? Not sure how often that's used. (At the least it should be marked depends_on 'mad' => :optional)

Contributor

mistydemeo commented Nov 20, 2012

When I built normalize, it picked up mad and linked against it. Looks like it's an optional dependency. Maybe it should be marked as a dependency? Not sure how often that's used. (At the least it should be marked depends_on 'mad' => :optional)

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Nov 20, 2012

Member

@mistydemeo I'm opposed to => :optional being used until @jacknagel's branch lands. Until then making it an option or a comment seems sensible.

Member

MikeMcQuaid commented Nov 20, 2012

@mistydemeo I'm opposed to => :optional being used until @jacknagel's branch lands. Until then making it an option or a comment seems sensible.

@bwagner

This comment has been minimized.

Show comment
Hide comment
@bwagner

bwagner Nov 20, 2012

Contributor

@mistydemeo It's indeed an optional feature (namely normalizing mp3 files). from the README file of normalize:

Dependencies

These dependencies are optional. Normalize doesn't require any other
packages to compile and run.

MAD library (http://www.underbit.com/products/mad/)

Normalize will use the MAD MPEG Audio Decoder library if you have it
(highly recommended). This gives normalize the ability to read mp3
files. MAD support in normalize was developed using MAD version
0.14.2b; earlier versions may not work.

You can run configure with the --without-mad option to turn off mp3
read support.

Contributor

bwagner commented Nov 20, 2012

@mistydemeo It's indeed an optional feature (namely normalizing mp3 files). from the README file of normalize:

Dependencies

These dependencies are optional. Normalize doesn't require any other
packages to compile and run.

MAD library (http://www.underbit.com/products/mad/)

Normalize will use the MAD MPEG Audio Decoder library if you have it
(highly recommended). This gives normalize the ability to read mp3
files. MAD support in normalize was developed using MAD version
0.14.2b; earlier versions may not work.

You can run configure with the --without-mad option to turn off mp3
read support.

@mistydemeo

This comment has been minimized.

Show comment
Hide comment
@mistydemeo

mistydemeo Nov 20, 2012

Contributor

If it's "highly recommended" let's turn it on by default and include an option to disable it:

option 'without-mad', 'Compile without MP3 support'

...

def install
  args = %W[--disable-debug --disable-dependency-tracking --prefix=#{prefix} --mandir=#{man}]
  args << "--without-mad" if build.include? "without-mad"

  system "./configure", *args
  ...
Contributor

mistydemeo commented Nov 20, 2012

If it's "highly recommended" let's turn it on by default and include an option to disable it:

option 'without-mad', 'Compile without MP3 support'

...

def install
  args = %W[--disable-debug --disable-dependency-tracking --prefix=#{prefix} --mandir=#{man}]
  args << "--without-mad" if build.include? "without-mad"

  system "./configure", *args
  ...
@mistydemeo

This comment has been minimized.

Show comment
Hide comment
@mistydemeo

mistydemeo Nov 20, 2012

Contributor

(Of, and of course depends_on 'mad' unless build.include? 'without-mad')

Contributor

mistydemeo commented Nov 20, 2012

(Of, and of course depends_on 'mad' unless build.include? 'without-mad')

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Nov 20, 2012

Member

Cool, seems reasonable.

Member

MikeMcQuaid commented Nov 20, 2012

Cool, seems reasonable.

@bwagner

This comment has been minimized.

Show comment
Hide comment
@bwagner

bwagner Nov 20, 2012

Contributor

Ok, changes according to your comments committed.

Contributor

bwagner commented Nov 20, 2012

Ok, changes according to your comments committed.

@adamv adamv closed this in 1409107 Jan 17, 2013

@adamv

This comment has been minimized.

Show comment
Hide comment
@adamv

adamv Jan 17, 2013

Contributor

Pulled, sorry for the delay.

Contributor

adamv commented Jan 17, 2013

Pulled, sorry for the delay.

@bwagner

This comment has been minimized.

Show comment
Hide comment
@bwagner

bwagner Jan 17, 2013

Contributor

Thank you!

Contributor

bwagner commented Jan 17, 2013

Thank you!

norioxkimura added a commit to norioxkimura/homebrew that referenced this pull request Jan 26, 2013

normalize 0.7.7
Closes Homebrew#16101.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>

@Homebrew Homebrew locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.