This repository has been archived by the owner. It is now read-only.

Libwebsockets support #16221

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

lipp commented Nov 25, 2012

Adds a formula for libwebsockets 1.0 release.

lipp commented Jan 27, 2013

Hey guys! Does this Formula meet your requirements?

Contributor

jacknagel commented Jan 27, 2013

Squash to a single commit please, thanks.

lipp commented Jan 28, 2013

How do I do that? I read this: https://github.com/ginatrapani/todo.txt-touch/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit . Am I correct, should I create a new branch and make a new pull request?
....
@jacknagel: Hope the commit was correct. This was my workflow (on my libwebsockets-support branch):

$ git reset a1c14684164154be5efeb7669d85888aaabbd192
$ git add Library/Formula/libwebsockets.rb
$ git commit -m "Add libwebsocket Formula"
$ git push --force origin libwebsockets-support
Contributor

adamv commented Feb 1, 2013

I tried to install but the sha had changed; since this is a "snapshot" URL that means it changes over time, right? Is there a stable version we can pull from instead?

lipp commented Feb 1, 2013

@adamv: Thanks for pointing that out! A more recent version (1.1) is available anyhow: http://git.warmcat.com/cgi-bin/cgit/libwebsockets/snapshot/libwebsockets-1.1-chrome26-firefox18.tar.gz. Maybe I mess something up with the sha... this is the sha1 I get:

$ sha1sum < /tmp/libwebsockets-1.1-chrome26-firefox18.tar.gz
$ 286167ff08eec75442f464f01d8a9461dd98eb4f  -

Could you be so kind to check, if this is the same you get?

Contributor

jacknagel commented Mar 10, 2013

I get a different hash each time I download this file; presumably it is being generated on the fly? We need something that doesn't change.

Contributor

adamv commented Mar 13, 2013

This needs to use a non-snapshot URL. We prefer tags.

But also, does this have a real homepage, other than the homepage of the git repo?

@adamv adamv closed this Mar 25, 2013

mxcl added a commit that referenced this pull request Apr 9, 2013

New formula: libwebsockets-1.22
Libwebsockets is the main C library implementation of the latest websockets protocol.

Refs #16221.

nesv added a commit to nesv/homebrew that referenced this pull request Apr 12, 2013

New formula: libwebsockets-1.22
Libwebsockets is the main C library implementation of the latest websockets protocol.

Refs #16221.

ekarulf added a commit to ekarulf/homebrew that referenced this pull request Apr 15, 2013

New formula: libwebsockets-1.22
Libwebsockets is the main C library implementation of the latest websockets protocol.

Refs #16221.

dshean added a commit to dshean/homebrew that referenced this pull request Sep 24, 2013

New formula: libwebsockets-1.22
Libwebsockets is the main C library implementation of the latest websockets protocol.

Refs #16221.

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.