lv2 audio tools #16232

Closed
wants to merge 6 commits into
from

Projects

None yet

2 participants

Contributor

Lv2 libs and plugins by David Robillard for working with Lv2 audio.

http://lv2plug.in
http://drobilla.net

Contributor
adamv commented Jan 7, 2013

Maintainers: any reason this hasn't been pulled yet?

@adamv adamv was assigned Jan 7, 2013
Contributor
benswift commented Jan 7, 2013

There was some discussion on the IRC channel (can't remember the person I spoke to, sorry) about the fact that there were several formulas in the same pull request, even though only lilv has an explicit dependency.

The reason for this is that they all depend (at run-time) on 'lv2', but because of the way that Dave has designed the rest of the tools ('unixy' do one thing well) the rest of them work together to provide various functions.

So it wouldn't work to have mda-lv2 (a set of audio plugins/ugens) without lv2, for instance. I realise that means that it's seven formulas in one pull request, and that does clutter things up a bit, but hopefully it's clear why I did it that way. If there's a better way, though, I'm open to suggestions.

Contributor
adamv commented Jan 7, 2013

It's true, we prefer separate pull requests for separate formulae, even if they are all going to be let in anyway.
It makes it easier to make individual fixes to them.

But I don't want to force that here if these are all ready to go.

Contributor
adamv commented Jan 8, 2013
==> Installing lilv dependency: sratom
==> Downloading http://download.drobilla.net/sratom-0.4.0.tar.bz2
/usr/bin/curl -f#LA Homebrew 0.9.3 (Ruby 1.8.7-358; Mac OS X 10.7.5) http://download.drobilla.net/sratom-0.4.0.tar.bz2 -o /usr/local/homebrew-cache/sratom-0.4.0.tar.bz2
######################################################################## 100.0%
/usr/bin/tar xf /usr/local/homebrew-cache/sratom-0.4.0.tar.bz2
==> ./waf configure --prefix=/usr/local/homebrew/Cellar/sratom/0.4.0
./waf configure --prefix=/usr/local/homebrew/Cellar/sratom/0.4.0 
Setting top to                           : /private/tmp/sratom-pXrf/sratom-0.4.0 
Setting out to                           : /private/tmp/sratom-pXrf/sratom-0.4.0/build 
Checking for 'gcc' (c compiler)          : cc 

Global Configuration 
 * Install prefix                        : /usr/local/homebrew/Cellar/sratom/0.4.0 
 * Debuggable build                      : False 
 * Build documentation                   : False 

Sratom Configuration 
Checking for program pkg-config          : /usr/local/opt/pkg-config/bin/pkg-config 
Checking for 'lv2' >= 1.0.0              : not found 
The configuration failed
(complete log in /private/tmp/sratom-pXrf/sratom-0.4.0/build/config.log)
==> Configuration
HOMEBREW_VERSION: 0.9.3
HEAD: a239543568e0a93a9fead7dd11ee7be113e4b740
HOMEBREW_CELLAR: /usr/local/homebrew/Cellar
CPU: quad-core 64-bit sandybridge
OS X: 10.7.5-x86_64
Xcode: 4.5.2
CLT: 4.5.0.0.1.1249367152
X11: 2.6.4 => /usr/X11
==> ENV
CC: cc
CXX: c++
MAKEFLAGS: -j4
CMAKE_PREFIX_PATH: /usr/local
CMAKE_INCLUDE_PATH: /usr/include/libxml2:/System/Library/Frameworks/OpenGL.framework/Versions/Current/Headers/
CMAKE_LIBRARY_PATH: /System/Library/Frameworks/OpenGL.framework/Versions/Current/Libraries
PKG_CONFIG_PATH: /usr/local/lib/pkgconfig
ACLOCAL_PATH: /usr/local/share/aclocal
OBJC: cc
PATH: /usr/local/homebrew/Library/ENV/4.3:/usr/local/opt/pkg-config/bin:/usr/bin:/bin:/usr/sbin:/sbin

Missing dep?

Contributor
adamv commented Jan 8, 2013

Please ensure that all formulae have the proper deps declared.

Contributor

Ok, sorry about that. I've fixed the deps problems (both compile-time and run-time with otool) and have re-done the patches as one-branch-per-formula (under benswift/homebrew). Would you prefer if I closed this request and submitted these other branches individually?

Happy to do whatever works best for you guys, and thanks for your patience while I get the hang of things.

Contributor
adamv commented Jan 14, 2013

If the is still one formula per commit, and this pull request was made from a non-master branch, then I'm OK with you git push -f-ing it here and I'll take a look when I get a chance.

Contributor

Ok, done. Cheers.

Contributor
adamv commented Jan 14, 2013

Made one comment, looks applicable to most of the formulae.

Contributor

Yep, fixed those problems.

Contributor
adamv commented Jan 14, 2013

Need commas between the arguments

Contributor

Added commas, it all works on my end. Sorry about that.

@adamv adamv closed this in ddd88b5 Jan 15, 2013
@norioxkimura norioxkimura added a commit to norioxkimura/homebrew that referenced this pull request Jan 16, 2013
@benswift @norioxkimura benswift + norioxkimura mda-lv2 1.0.0
http://drobilla.net/software/mda-lv2/

Closes #16232.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
48d9aab
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.