smlnj: Don't download on demand & build on Xcode. #16355

Closed
wants to merge 1 commit into
from

3 participants

@samueljohn

Given superenv would allow ENV.m32 (as suggested in issue #16350), this is my attempt to fix smlnj. I gave up earlier.

But thanks to superenv, I was able to fix things and make it build on Xcode only, too.

Don't pull unless superenv allows 32bit builds, too

@samueljohn

Any user of smlnj here? Please test.

@samueljohn samueljohn referenced this pull request in Homebrew/homebrew-science Dec 5, 2012
Closed

New Formula: rml-mmc #22

@adamv

I'm willing to pull this untested, but I don't use smlnj to have any opinion.

@samueljohn

@adamv this needs #16350 (or a similar fix). I don't know how you feel about #16350. I think it's worth it but implementation should be discussed with Max.

@samueljohn

Updated based on your review. But waiting for #16350 !!

@adamv adamv added a commit that closed this pull request Jan 26, 2013
@samueljohn samueljohn smlnj: Don't download on demand & build on Xcode.
- Activeted two additional targets.

Closes #16355.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
c40c857
@adamv adamv closed this in c40c857 Jan 26, 2013
@owend

Works great here! (10.8.2, xcode 4.5.2) Helpful for the coursera ML class. :)

@samueljohn

Cool :-)

@norioxkimura norioxkimura added a commit to norioxkimura/homebrew that referenced this pull request Jan 26, 2013
@samueljohn samueljohn smlnj: Don't download on demand & build on Xcode.
- Activeted two additional targets.

Closes #16355.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
eebe84f
@rajeeja rajeeja pushed a commit that referenced this pull request Apr 19, 2013
@samueljohn samueljohn smlnj: Don't download on demand & build on Xcode.
- Activeted two additional targets.

Closes #16355.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
58bb372
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.