This repository has been archived by the owner. It is now read-only.

smlnj: Don't download on demand & build on Xcode. #16355

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

samueljohn commented Dec 2, 2012

Given superenv would allow ENV.m32 (as suggested in issue #16350), this is my attempt to fix smlnj. I gave up earlier.

But thanks to superenv, I was able to fix things and make it build on Xcode only, too.

Don't pull unless superenv allows 32bit builds, too

Contributor

samueljohn commented Dec 2, 2012

Any user of smlnj here? Please test.

@samueljohn samueljohn referenced this pull request in Homebrew/homebrew-science Dec 5, 2012

Closed

New Formula: rml-mmc #22

Contributor

adamv commented Dec 29, 2012

I'm willing to pull this untested, but I don't use smlnj to have any opinion.

Contributor

samueljohn commented Dec 29, 2012

@adamv this needs #16350 (or a similar fix). I don't know how you feel about #16350. I think it's worth it but implementation should be discussed with Max.

Contributor

samueljohn commented Dec 30, 2012

Updated based on your review. But waiting for #16350 !!

smlnj: Don't download on demand & build on Xcode.
- Activeted two additional targets.

@adamv adamv closed this in c40c857 Jan 26, 2013

owend commented Jan 26, 2013

Works great here! (10.8.2, xcode 4.5.2) Helpful for the coursera ML class. :)

Contributor

samueljohn commented Jan 26, 2013

Cool :-)

norioxkimura added a commit to norioxkimura/homebrew that referenced this pull request Jan 26, 2013

smlnj: Don't download on demand & build on Xcode.
- Activeted two additional targets.

Closes #16355.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.