This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
Cleanup Elasticsearch formula and add the option to install HEAD version
#16844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup of the Elasticsearch formula: 1/ Fixed incorrectly installed Sigar libraries on Mac OS X Move all neccessary files to `libexec/sigar`. 2/ Removed manipulating the bin scripts, use ES_HOME variable Instead of hardcoding paths to Homebrew locations in the `bin/elasticsearch` and `bin/plugin` scripts, set up the ES_HOME environment variable in the `bin/elasticsearch.in.sh` properly. Also, simplify the Regex for replacing path to Elasticsearch classes (`--classpath`) in the `bin/plugin` script and use the `ES_CLASSPATH` variable. 3/ Simplified elasticsearch.yml configuration Reorganize the commands, use `sub` instead of `gsub`. 4/ Cleaned up the caveats/info section Remove redundant information.
Allow to install Elasticsearch from the source:
$ brew install elasticsearch --HEAD
(You need a working Maven installation -- `brew install maven` to install it with Homebrew.)
|
Seems good to me. Will merge shortly unless other maintainers complain. |
|
@MikeMcQuaid OK to pull? |
|
Go for it. |
|
Thanks! |
|
Thanks for the cleanups! |
dholm
pushed a commit
to dholm/homebrew
that referenced
this pull request
Jan 14, 2013
Allow to install Elasticsearch from the source:
$ brew install elasticsearch --HEAD
(You need a working Maven installation -- `brew install maven` to install it with Homebrew.)
Closes Homebrew#16844.
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup of the Elasticsearch formula
Allow to install Elasticsearch from the source