gmp 5.1.1 #16906

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
@ghost

ghost commented Jan 5, 2013

No description provided.

Contributor

adamv commented Jan 5, 2013

What issues? Will they be fixed shortly? If not, close this.

Contributor

adamv commented Jan 7, 2013

Would like to know why env :std is needed for the tests to run before pulling.

Contributor

jacknagel commented Jan 8, 2013

Can you post logs from the failure?

Contributor

Sharpie commented Jan 10, 2013

Here's the compile line from one of the failing test binaries:

/usr/bin/make  t-asmtype t-aors_1 t-divrem_1 t-mod_1 t-fat t-get_d t-instrument t-iord_u t-mp_bases t-perfsqr t-scan logic t-toom22 t-toom32 t-toom33 t-toom42 t-toom43 t-toom44 t-toom52 t-toom53 t-toom54 t-toom62 t-toom63 t-toom6h t-toom8h t-toom2-sqr t-toom3-sqr t-toom4-sqr t-toom6-sqr t-toom8-sqr t-mul t-mullo t-mulmod_bnm1 t-sqrmod_bnm1 t-mulmid t-hgcd t-hgcd_appr t-matrix22 t-invert t-div t-bdiv t-broot t-brootinv
cc -DHAVE_CONFIG_H -I. -I../.. -I../.. -I../../tests    -O2 -pedantic -fomit-frame-pointer -m64 -mtune=k8 -march=k8 -c t-asmtype.c
brew: superenv removed: -O2 -pedantic -m64 -mtune=k8 -march=k8

Shot in the dark, but perhaps it has something to do with the flags superenv is removing?

Contributor

geoff-codes commented Jan 27, 2013

Hi! Please see my first! ever! pull request. Perhaps it may be of utility. mxcl#17345

@ghost

ghost commented Feb 25, 2013

I have managed to make it work with superenv and also to makes it properly discover processor (in my case core 2 instead of -mtune=k8) by removing --build=x86_64-apple-darwin.

ghost closed this Feb 25, 2013

@ghost

ghost commented Feb 25, 2013

Should gcc still be supported ? or should we start anew and see if these got fixed ? (I could figure out gcc build for fails_with, but then there was also issue with llvm where I couldn't figure out build number)

    # Reports of problems using gcc 4.0 on Leopard
    # https://github.com/mxcl/homebrew/issues/issue/2302
    # Also force use of 4.2 on 10.6 in case a user has changed the default
    # Do not force if xcode > 4.2 since it does not have /usr/bin/gcc-4.2 as default
    # FIXME convert this to appropriate fails_with annotations
    ENV.gcc if MacOS::Xcode.provides_gcc?

What is official stance on supporting 32 bit builds ?

ghost reopened this Feb 25, 2013

@ghost

ghost commented Feb 28, 2013

ping @ anyone. I would need some input here.

Owner

MikeMcQuaid commented Feb 28, 2013

@humdedum GCC and 32-bit builds should be supported if possible but supporting 10.8/10.7/10.6 (in that order), SuperEnv and Clang should take priority. If we break Leopard or GCC in doing so then someone will report it and we'll integrate a fix.

@ghost

ghost commented Mar 1, 2013

Thanks @MikeMcQuaid! Would you please review this ?

I have tested it with all 4 with/without --32-bit/--env=std combinations on 10.8.2 and 10.7.5.

--build=none-apple-darwin is removed as: WARNING: the "none" host is obsolete, use --disable-assembly which was not used as it was causing build to fail. -m32 and ABI=32 is both necessary and enough.

Owner

MikeMcQuaid commented Mar 1, 2013

Looks good to me. Will give it a day or two for someone else to ok it (or not) and will merge it then.

Owner

MikeMcQuaid commented Mar 3, 2013

Pushed, thanks.

@nesv nesv added a commit to nesv/homebrew that referenced this pull request Apr 12, 2013

@nesv Stefan + nesv gmp 5.1.1
Closes #16906.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
8aa1cdc

xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.