GTK Theme Switch #16967

Closed
wants to merge 2 commits into
from

Projects

None yet

5 participants

@LukeCarrier

I amended a formula for GTK Theme Switch submitted in #11483, which was rejected because the submitter disappeared. I've remedied the original issue, audited and successfully installed/ran.

@adamv

Can you look at the brew install -v gtkthemeswitch output and make sure this isn't missing a dep on pkg-config? Stuff that uses GTK tends to, and MacPorts declares it too.

@adamv

Ping.

@LukeCarrier

Apologies for the slow response, I've been a little swamped.

I just ran the install on a different prefix; pkg-config is already installed as part of the install process (another dependency, likely). Is it necessary to list it again? From the install:

==> Installing gtk-theme-switch dependency: pkg-config

@adamv

A user may have uninstalled pkg-config in between installing gtk and then later installing this recipe.

@adamv

Is this hard-coding gcc?

@LukeCarrier

The path isn't hardcoded (GCC = gcc in Makefile), but it does require it to be on PATH. Do I need to depend on anything else, or can we assume that Xcode's command line tools are available?

@MikeMcQuaid
Homebrew member
@LukeCarrier

So even if the code correctly compiles with the LLVM-GCC interface, I should depend on GCC? Or can I not rely on gcc being a link to llvm-gcc?

@MikeMcQuaid
Homebrew member

Don't rely on it being a link and try and use Clang when possible (as llvm-gcc is going away soon).

@mistydemeo

Homebrew sets the CC and CXX environment variables; in general we prefer those to be used because it lets us control compiler choice at the homebrew level.

@LukeCarrier
@LukeCarrier

Sorry for wasting you time, but this will never be finished; I returned my MBP for reasons that're beyond the scope of this PR.

@jjpe

What's necessary to get this working with up-to-date versions of the various packages that are involved? If it's not all that much effort I'd rather not look at a butt-ugly Inkscape when I need it (IMO GTK really needs a better default theme than something that looks like it originated in the 90s, the current default is a huge eye sore).

@MikeMcQuaid
Homebrew member

@jjpe No idea, I'm afraid.

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.