Fix and Update scotch #16977

Closed
wants to merge 2 commits into from

2 participants

@wdeconinck

Previous formula was not compiling anymore.
Scotch needs more recent POSIX standard implementations of pthread than OSX supports.
Disabling pthread in Scotch fixes the compilation

@Sharpie

Is the pthread issue specific to the new 6.x version of Scotch and is there an upstream discussion or issue that we can track to keep tabs on this?

@wdeconinck

This post in stackoverflow answers the question about pthread and missing barrier functionality
http://stackoverflow.com/questions/8920803/pthread-and-gcc-compiling-issue-on-os-x

The previous version of scotch (version 5.1.2) did not make use of pthread_barrier, and worked with the PTHREAD flags ON, so YES, this is specific to the new 6.x version.

The threads don't offer substantial advantage, and mpi is used for distributed graph partitioning anyway. No functionality is lost.

However, compilation of version 5.1.2 was not working any longer due to an unrelated problem:
Something is now wrong with the MPI environment.
Some checks showed that ENV['MPICC'] equals 'nil'. In other words the mpi_path variable in the function 'modify_build_environment' is nil (which mpicc --> nil), while this returns the correct path in the 'satisfied?' function. Perhaps the introduction of superenv has something to do with it? I now trust that the correct mpicc is found without specifying the path.

@Sharpie

The MPI issue is related to superenv and is being tracked in #16409. Looks like we'll pull a workaround soon.

@Sharpie

Is MPI working now that #16409 has landed?

@wdeconinck

Yes, the mpi-part works again now. Thanks! Still needs the pthread disabled though for now.

@Sharpie Sharpie added a commit that closed this pull request Jan 14, 2013
@wdeconinck wdeconinck scotch: Update to 6.0
Also disables pthreads as OS X doesn't implement the required optional parts of
the POSIX spec:

  http://stackoverflow.com/questions/8920803/pthread-and-gcc-compiling-issue-on-os-x

Closes #16977.

Signed-off-by: Charlie Sharpsteen <source@sharpsteen.net>
7078796
@Sharpie Sharpie closed this in 7078796 Jan 14, 2013
@Sharpie

Pulled. I squashed the commits since the second really just undoes deletions introduced in the first.

@wdeconinck wdeconinck deleted the wdeconinck:scotch_update branch Jan 15, 2013
@norioxkimura norioxkimura added a commit to norioxkimura/homebrew that referenced this pull request Jan 16, 2013
@wdeconinck wdeconinck scotch: Update to 6.0
Also disables pthreads as OS X doesn't implement the required optional parts of
the POSIX spec:

  http://stackoverflow.com/questions/8920803/pthread-and-gcc-compiling-issue-on-os-x

Closes #16977.

Signed-off-by: Charlie Sharpsteen <source@sharpsteen.net>
70004dc
@rajeeja rajeeja pushed a commit that referenced this pull request Apr 19, 2013
@wdeconinck wdeconinck scotch: Update to 6.0
Also disables pthreads as OS X doesn't implement the required optional parts of
the POSIX spec:

  http://stackoverflow.com/questions/8920803/pthread-and-gcc-compiling-issue-on-os-x

Closes #16977.

Signed-off-by: Charlie Sharpsteen <source@sharpsteen.net>
ef743d7
@sjackman sjackman pushed a commit to sjackman/homebrew that referenced this pull request Nov 15, 2013
@wdeconinck wdeconinck scotch: Update to 6.0
Also disables pthreads as OS X doesn't implement the required optional parts of
the POSIX spec:

  http://stackoverflow.com/questions/8920803/pthread-and-gcc-compiling-issue-on-os-x

Closes #16977.

Signed-off-by: Charlie Sharpsteen <source@sharpsteen.net>
f2eeae1
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.