python: Allow --with-brewed-tk. #17008

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

Contributor
  • Fixes #16574.
  • Improve Tkinter test by actually calling Tk()
  • Check for /Library/Frameworks/Tk.framework no longer needed.
  • Also remove Tk.framework check from python3.rb
  • Fix PYTHONFRAMEWORKDIR so that python-config --ldflags is useful.
Contributor

@mikemcquaid I had to open a new PR since I already deleted my old one. Now it works - the fix was easy.

Owner

Don't we need to do a similar patch for Python3?

Contributor

Python3 has the right flags:

python3.3-config --ldflags
-L/homebrew/Cellar/python3/3.3.0/Frameworks/Python.framework/Versions/3.3/lib/python3.3/config-3.3m -ldl -framework CoreFoundation -lpython3.3m

Python3 with a brewed tkinter would be another pull request.

@samueljohn samueljohn python: Allow --with-brewed-tk.
- Fixes #16574.
- Improve Tkinter test by actually calling Tk()
- Check for /Library/Frameworks/Tk.framework no longer needed.
- Also remove Tk.framework check from python3.rb
- Fix PYTHONFRAMEWORKDIR so that `python-config --ldflags` is useful.
90f5168
Contributor

@adamv sadly, removed the little 🐍

Contributor

@mikemcquaid let's try again please. Python3 won't break this time.

@adamv adamv closed this in 3defd78 Jan 15, 2013
Contributor

I tested this for program that requires brewed-tk (fails with apple tk) and it seems to work as expected! Thanks!

@norioxkimura norioxkimura added a commit to norioxkimura/homebrew that referenced this pull request Jan 16, 2013
@samueljohn @norioxkimura samueljohn + norioxkimura python: Allow --with-brewed-tk.
- Fixes #16574.
- Improve Tkinter test by actually calling Tk()
- Check for /Library/Frameworks/Tk.framework no longer needed.
- Also remove Tk.framework check from python3.rb
- Fix PYTHONFRAMEWORKDIR so that `python-config --ldflags` is useful.

Closes #17008.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
6137dcd
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.