adding Coin 3.1.3 #17689

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

XL64 commented Feb 8, 2013

A new recipe adding coin library.

XL64 commented Feb 8, 2013

Ok I'll try to fix that, sorry.
Not sure what means "stable version 3.1.3 is redundant with version scanned from URL" will google it.

Contributor

adamv commented Feb 8, 2013

It means that you can remove the version from the formula

XL64 commented Feb 8, 2013

Ok I understood it after some tests, will correct my Pull request.

XL64 commented Feb 8, 2013

I pushed changed to fix "brew audit coin", do I have anything else to do than push it into my branch ?

Contributor

adamv commented Mar 9, 2013

Please squash to a single commit for review, thanks.

@jacknagel jacknagel commented on an outdated diff Mar 11, 2013

Library/Formula/coin.rb
+# Documentation: https://github.com/mxcl/homebrew/wiki/Formula-Cookbook
+
+class Coin < Formula
+ homepage 'https://bitbucket.org/Coin3D/coin/wiki/Home'
+ url 'https://bitbucket.org/Coin3D/coin/downloads/Coin-3.1.3.tar.gz'
+ sha1 '8e9f05628461963623686d3ec53102214e233dd1'
+
+ def install
+ system "./configure", "--disable-debug", "--disable-dependency-tracking",
+ "--prefix=#{prefix}", "--with-framework-prefix=#{lib}"
+ system "make install"
+ end
+
+ def test
+ system "test -e #{lib}/libCoin.dylib"
+ end
@jacknagel

jacknagel Mar 11, 2013

Contributor

If there's not an easy way to test this, you can just remove the test; testing that the file exists isn't necessary.

@jacknagel jacknagel commented on an outdated diff Mar 11, 2013

Library/Formula/coin.rb
@@ -0,0 +1,19 @@
+require 'formula'
+
+# Documentation: https://github.com/mxcl/homebrew/wiki/Formula-Cookbook
@jacknagel

jacknagel Mar 11, 2013

Contributor

Remove comment

Contributor

adamv commented Mar 14, 2013

Please squash to a single commit, thanks.

Contributor

adamv commented Apr 13, 2013

Please squash to a single commit and rebase on master.

Xavier Lacoste adding Coin 3.1.3 2c73b2f

XL64 commented Apr 15, 2013

I'm not used to github yet but now rebase/squash must be done.

XL

Contributor

DanLipsitt commented May 4, 2013

Anybody know why this pull request isn't showing up in brew search?

$ brew search Coin
No formula found for "Coin". Searching open pull requests...
$ brew --version
0.9.4

adamv closed this in d8c3f1b May 4, 2013

@handyman5 handyman5 pushed a commit to handyman5/homebrew that referenced this pull request Oct 7, 2013

@adamv Xavier Lacoste + adamv Coin 3.1.3
Closes #17689.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
abb0e73

xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.