Add brew-run-configure.sh to contributions, attempt number 2 #17939

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@cooljeanius

I screwed up the branch I was originally going to send this from, so instead it's coming from a third branch. Anyway, differences between this and #16248 include:

  • Being from a non-master branch
  • I have now included directories for testing my script in (this was something @adamv was unsure about last time)
  • The script now has more logging and comments, and does its checks better.
System Administrator New branch for my brew-run-configure.sh script because I screwed up m…
…y last one

- add brew-run-configure.sh
- add some directories for testing it in
d971ff3
@adamv
Contributor
adamv commented Apr 30, 2013

Maintainers: is this something we want or not?

@MikeMcQuaid
Member

Remind me what this does?

@cooljeanius

It's basically an expansion on brew diy to make installing stuff into Homebrew's Cellar easier

@MikeMcQuaid
Member

Could/should this be part of brew diy? I don't see a harm in having it in Contributions regardless.

@cooljeanius

well if this were added to brew diy itself, it'd have to be rewritten in Ruby, and I don't know Ruby, so someone else would have to do that

@MikeMcQuaid
Member

Being very stupid here but can you explain what this does that diy doesnt? I'm just wondering if we want two similar commands written in different languages.

(An aside: I didn't know Ruby before contributing to Homebrew either. I now have a job writing Ruby.)

@cooljeanius

brew diy just tells you the configure flag to pass to ./configure, this script actually applies that flag for you and runs it.

@MikeMcQuaid
Member

Yeh, in that case I think this should be an argument e.g. brew diy --configure.

@adamv adamv commented on the diff Aug 29, 2013
Library/Homebrew/test/configuring/cmake/Demo/.gitignore
@@ -0,0 +1 @@
+#
@adamv
adamv Aug 29, 2013 Contributor

What are these gitignore files for?

@cooljeanius
cooljeanius Aug 29, 2013

To keep the directories from being empty.

@adamv
Contributor
adamv commented Aug 29, 2013

If another maintainer wants this include, please work towards inclusion; otherwise I recommend it be a small project external to Homebrew itself. I'll close in a couple days unless another maintainer steps in.

@MikeMcQuaid
Member

I'm -1 on this as-is.

@adamv
Contributor
adamv commented Aug 29, 2013

Passing on this for inclusion in core, but would link it from the wiki: https://github.com/mxcl/homebrew/wiki/External-Commands

@adamv adamv closed this Aug 29, 2013
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.