This repository has been archived by the owner. It is now read-only.

libmagic optional python bindings #17994

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants

update to include building python bindings.

Update Library/Formula/libmagic.rb
update to include building python bindings.

@mistydemeo mistydemeo commented on an outdated diff Feb 21, 2013

Library/Formula/libmagic.rb
@@ -9,13 +9,19 @@ class Libmagic < Formula
# Fixed upstream, should be in next release
# See http://bugs.gw.com/view.php?id=230
def patches; DATA; end if MacOS.version < :lion
-
+
@mistydemeo

mistydemeo Feb 21, 2013

Contributor

Watch your whitespace ;)

@jacknagel jacknagel commented on the diff Mar 4, 2013

Library/Formula/libmagic.rb
@@ -10,12 +10,19 @@ class Libmagic < Formula
# See http://bugs.gw.com/view.php?id=230
def patches; DATA; end if MacOS.version < :lion
+ option "python", "Build Python bindings."
@jacknagel

jacknagel Mar 4, 2013

Contributor

Call this option "with-python"

Contributor

jacknagel commented Mar 10, 2013

This seems to install the python stuff outside of its keg... /cc @samueljohn

Contributor

samueljohn commented Mar 11, 2013

Please see "How to create a formula with nice Python bindings" section in https://github.com/mxcl/homebrew/wiki/Homebrew-and-Python.

I hope to improve python support in the future, so that we can just use --prefix=... but right now we need few more option to be passed to python.

Contributor

samueljohn commented Mar 19, 2013

Or we wait just until #18588 is ready, so the --prefix=... works as expected.

@ghost ghost assigned samueljohn Mar 19, 2013

Contributor

samueljohn commented Jun 13, 2013

Included in 6e97ac1. With the new depends_on :python this becomes quite easy. Thanks for triggering this! And your patience.

@samueljohn samueljohn closed this Jun 13, 2013

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.