This repository has been archived by the owner. It is now read-only.

Adding rlwrap to clojure #18010

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
@ghost

ghost commented Feb 22, 2013

The clojure REPL doesn not have command line history, which makes it
really frustrating to use.

This PR adds 'rlwrap' to the clojure REPL invocation.

Add 'rlwrap' to the clojure REPL.
The clojure REPL doesn not have command line history, which makes it
really frustrating to use.

This PR adds 'rlwrap' to the clojure REPL invocation.
Contributor

adamv commented Feb 22, 2013

Note: If you make pull requests from non-master branches then you can git push -f to update them in-place.

@adamv: If I use -f doesn't that squash all the comments on the commit?

Contributor

adamv commented Feb 22, 2013

It does a force push, you still have to squash with git rebase -i <target>

Sorry, I meant to ask, "if I use -f, doesn't it cause the conversation surrounding the proposed commit (i.e., "is 'rlwrap' really a hard dependency?") to get removed?"

Contributor

adamv commented Feb 22, 2013

Oh, well I guess GitHub has some issues in that regard, but it is preferable to lose comments than get new pull requests for every edit.

Fair enough. I'll keep that in mind for next time, thanks!

On Fri, Feb 22, 2013 at 9:45 AM, Adam Vandenberg
notifications@github.comwrote:

Oh, well I guess GitHub has some issues in that regard, but it is
preferable to lose comments than get new pull requests for every edit.


Reply to this email directly or view it on GitHubhttps://github.com/mxcl/homebrew/pull/18010#issuecomment-13957798.

Thanks,
Weiser

@ghost

ghost commented Feb 25, 2013

Do I need to do anything more to get this PR merged?

Contributor

adamv commented Feb 25, 2013

Should rlwrap be optional?

@ghost

ghost commented Feb 25, 2013

Are you Ok if I make it recommended, or do you really want it to be optional?

My 2c as a (so far) only very casual Clojure user: I started using rlwrap with it almost immediately when I got started, as it was quite painful to use without. Lack of readline in any REPL feels like a killer.

As long as there are no serious concerns about the readline dependency causing problems (seems like it's keg-only to limit it stomping on the OS defaults?) I'd definitely +1 making it recommended instead of optional.

Contributor

michaelklishin commented Mar 13, 2013

I agree with @bitprophet. To put things in perspective, with Leiningen and its built-in REPL the standard Clojure REPL is not very useful but it's a welcome improvement for beginners who don't know about Leiningen yet.

Contributor

adamv commented Mar 18, 2013

Can we get this squash to a single commit and rebased on master? Thanks.

@ghost ghost assigned adamv May 15, 2013

@adamv adamv closed this in 569c2c0 May 22, 2013

handyman5 pushed a commit to handyman5/homebrew that referenced this pull request Oct 7, 2013

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.