Update libnfc to 1.7.0-rc6, add USB CDC/ACM patch #18272

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@hugovincent

Update libnfc to latest version, add config file (generated by brew, in prefix)
and add a patch to support PN532-based NFC devices with USB CDC/ACM
interfaces, such as the OpenPCD2 (http://www.openbeacon.org/OpenPCD_2_RFID_Reader_for_13.56MHz). This also removes the "with-pn532_uart" option as this is now handled automatically. Similarly, the "--enable-serial-autoprobe" option to libnfc has been deprecated in favour of an option in the config file.

@jacknagel jacknagel commented on an outdated diff Mar 10, 2013
Library/Formula/libnfc.rb
system "./configure", *args
system "make install"
+ system "mkdir -p #{prefix}/etc/nfc"
+ system "echo allow_intrusive_scan=yes > #{prefix}/etc/nfc/libnfc.conf"
@jacknagel
jacknagel Mar 10, 2013

These two lines can be

(prefix/'etc/nfc/libnfc.conf').write "allow_intrusive_scan=yes"
@jacknagel jacknagel commented on an outdated diff Mar 10, 2013
Library/Formula/libnfc.rb
@@ -24,13 +23,10 @@ def install
--prefix=#{prefix}
]
- if build.include? 'with-pn532_uart'
- args << "--enable-serial-autoprobe"
- args << "--with-drivers=pn532_uart"
- end
-
system "./configure", *args
@jacknagel
jacknagel Mar 10, 2013

Now that we're not conditionally pushing things onto args, should just inline them into system "./configure", ...

@hugovincent hugovincent Update libnfc to 1.7.0-rc6, add USB CDC/ACM patch
Update libnfc to latest, add config file (generated by brew, in prefix)
and add a patch to support PN532-based NFC devices with USB CDC/ACM
interfaces, such as the OpenPCD2
(http://www.openbeacon.org/OpenPCD_2_RFID_Reader_for_13.56MHz)

(Formula simplified thanks to jacknagel).
73dc0ca
@hugovincent

Merged Jacknagel's proposed changes. Thanks!

@adamv adamv was assigned Apr 30, 2013
@adamv adamv added a commit that closed this pull request May 2, 2013
@hugovincent hugovincent libnfc 1.7.0-rc6
Update libnfc to latest, add config file (generated by brew, in prefix)
and add a patch to support PN532-based NFC devices with USB CDC/ACM
interfaces, such as the OpenPCD2

http://www.openbeacon.org/OpenPCD_2_RFID_Reader_for_13.56MHz

Closes #18272.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
53ac99a
@adamv adamv closed this in 53ac99a May 2, 2013
@adamv
adamv commented May 2, 2013

Pulled, sorry for the delay. I see there's a newer rc7 release as well; if you open a pull request for that I can merge it too.

@handyman5 handyman5 pushed a commit to handyman5/homebrew that referenced this pull request Oct 7, 2013
@hugovincent hugovincent libnfc 1.7.0-rc6
Update libnfc to latest, add config file (generated by brew, in prefix)
and add a patch to support PN532-based NFC devices with USB CDC/ACM
interfaces, such as the OpenPCD2

http://www.openbeacon.org/OpenPCD_2_RFID_Reader_for_13.56MHz

Closes #18272.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
4db7d86
@draftycode draftycode added a commit to draftycode/homebrew that referenced this pull request Feb 24, 2014
@hugovincent hugovincent libnfc 1.7.0-rc6
Update libnfc to latest, add config file (generated by brew, in prefix)
and add a patch to support PN532-based NFC devices with USB CDC/ACM
interfaces, such as the OpenPCD2

http://www.openbeacon.org/OpenPCD_2_RFID_Reader_for_13.56MHz

Closes #18272.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
4615ca0
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.