libpurple: Allowing support for perl plugins. #18312

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

ike18t commented Mar 7, 2013

Removing the disable-perl flag from libpurple

Contributor

adamv commented Mar 7, 2013

This needs to be made optional, or tested on all of 10.6, 10.7 and 10.8.

Also, please prefix commit messages with the formula in question, such as:

libpurple: remove disable-perl flag

What OS did you test this on?

Contributor

ike18t commented Mar 7, 2013

Initially I tested it on 10.8.2 and it worked no problem. After your comment I had a coworker install using the change as well on his mbp running 10.7.5 which worked no problem but another coworker who has 10.6.8 tried and it failed due to not having perl-headers installed. Since the latest versions of OSX have no problem by default would you prefer I make the option "without-perl" to accomodate the newer versions going forward or "with-perl" so it's more of an option to have it in the first place?

Thanks!
Ike

Contributor

adamv commented Mar 7, 2013

Thanks for doing this testing!

We should make it an option; perhaps we could default it to off on Snow Leopard (and below) only.

Contributor

ike18t commented Mar 8, 2013

Hey man,

Was this what you had in mind?

adamv referenced this pull request May 15, 2013

Closed

Sort out IM libraries/apps #19840

adamv closed this in e756d7d Jun 30, 2013

@handyman5 handyman5 pushed a commit to handyman5/homebrew that referenced this pull request Oct 7, 2013

@ike18t @adamv ike18t + adamv libpurple: make perl support optional
Closes #18312.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
237e498

xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.