add ucspi-tcp #18342

Closed
wants to merge 1 commit into
from

5 participants

@dpk
dpk commented Mar 8, 2013

ucspi-tcp is Daniel J. Bernstein's set of command-line tools for building network applications. This commit adds it as a formula for Homebrew, with the popular IPv6 patch from Fefe.

@sbp
sbp commented Mar 8, 2013

Can you add an sha1 to the patch?

@adamv

@sbp we don't currently support checksums on patches

@sbp
sbp commented Mar 8, 2013

Do you want the commits to be squashed after making the change requested above?

@dpk
dpk commented Mar 9, 2013

@adamv Done, thanks to @sbp!

@jacknagel

Squash to a single commit, please

@jacknagel
Error: Will not overwrite /private/tmp/ucspi-tcp-okDm/ucspi-tcp-0.88/conf-home

need to remove the file before .writeing it.

==> Cleaning
Warning: A top-level "man" directory was found.
Homebrew requires that man pages live under share.
This can often be fixed by passing "--mandir=#{man}" to configure.

man pages need to go under share

@ferriswheel

hello,

when will this brew be available?

@adamv

Jack's comments need to be addressed.

@adamv

How did this even install for you with the write error?

@adamv

conf-cc and conf-ld hard-code gcc; ld uses obsolete options.

@dpk

With the man page problem and the build failure (which I blame entirely on @sbp), I decided to also make an alteration that would make the IPv6 patch optional. I still haven't got round to that. On it now.

@dpk

Hmm, I don't see how to find the compiler options that conf-cc and conf-ld should use from the Homebrew environment. Is there a variable this is kept in?

@adamv

ENV.cc and ENV.cflags, etc.; check out ENV.rb.

@adamv

Getting:

Error: Will not overwrite /private/tmp/ucspi-tcp-LULf/ucspi-tcp-0.88/conf-home

@adamv

Weirdly I'm not getting the Warning: A top-level "man" directory was found. warning even though a top level man is being installed. Wonder if we broke this check.

@adamv

Oh, this audit is only triggered now for ARGV.homebrew_developer.

I must have been asleep when homebrew_developer happened.

@adamv adamv added a commit that closed this pull request Jun 14, 2013
@dpk dpk ucspi-tcp 0.88
Closes #18342.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
a02008e
@adamv adamv closed this in a02008e Jun 14, 2013
@adamv

Updated and pulled, thanks for the submission!

@handyman5 handyman5 pushed a commit to handyman5/homebrew that referenced this pull request Oct 7, 2013
@dpk dpk ucspi-tcp 0.88
Closes #18342.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
96a3948
@shelhamer shelhamer added a commit that referenced this pull request Apr 18, 2014
@dpk dpk ucspi-tcp 0.88
Closes #18342.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
ae7ba67
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.