This repository has been archived by the owner. It is now read-only.

Add pseudo #18912

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

adamv commented Apr 2, 2013

Not commenting on the usefulness of this software, but it was written over two days a couple months ago.

Contributor

bjeanes commented Apr 2, 2013

Yup, but it's an extremely simple utility so I wouldn't expect much more than that for a v1, to be honest. I've been using it for a few weeks now. I just bought a new machine so felt like making it a bit easier to install.

Library/Formula/pseudo.rb
+
+ def install
+ system "make"
+ system "mkdir -p #{prefix}/{bin,share/man/man1}"
@bjeanes

bjeanes Apr 2, 2013

Contributor

This should really done by the make install but seems not to be. It's a bit of a kludge and I'm not sure if there's a better way to do this. Suggestions welcome...

@jacknagel

jacknagel Apr 3, 2013

Contributor
bin.mkpath
man1.mkpath
Library/Formula/pseudo.rb
+ def install
+ system "make"
+ system "mkdir -p #{prefix}/{bin,share/man/man1}"
+ system "make install PREFIX=#{prefix}"
@jacknagel

jacknagel Apr 3, 2013

Contributor

quote each arg separately: system "make", ...

@bjeanes

bjeanes Apr 3, 2013

Contributor

No problem. The comments generated by brew create have system "make install" as an example, so was just copying that. Perhaps that should be updated, if the preference is different...

Library/Formula/pseudo.rb
+ end
+
+ test do
+ system "pseudo --version"
@jacknagel

jacknagel Apr 3, 2013

Contributor

same here, also use #{bin}/psuedo

Contributor

jacknagel commented Apr 3, 2013

Squash to a single commit, please.

Contributor

bjeanes commented Apr 3, 2013

Feedback incorporated and new squashed commit pushed.

Contributor

adamv commented Apr 30, 2013

@jacknagel accept this or reject?

Contributor

jacknagel commented Apr 30, 2013

I guess if the expectation is that it will probably never see updates, packaging it isn't really necessary.

Contributor

adamv commented Jun 23, 2013

Passing on this.

@adamv adamv closed this Jun 23, 2013

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.