This repository has been archived by the owner. It is now read-only.

fftw 3.3: enable AVX instruction set for SIMD speedup #19002

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

sxprophet commented Apr 6, 2013

No description provided.

Contributor

mistydemeo commented Apr 6, 2013

Not all of the compilers in Xcode support AVX; only clang does. (GCC didn't support it until 4.6, which is newer than what Xcode provides.) This should probably only be enabeld if ENV.compiler == :clang.

Not all of the Intel processors in hardware we support have AVX either; just Sandy Bridge and Ivy Bridge. This should only be enabled on hardware that can use it.

Contributor

samueljohn commented Apr 7, 2013

Can we have the gfortran and fftw in separate pull requests? The title does not mention gfortran at all.

I am in favor of adding cloog and isl to gfortran but I need to test this and this is easier in separate requests.
I am willing to test the gfortran stuff - ping me in a new PR.

I have a core 2 duo and sandy bridge mac, so I can test that stuff (but I am not testing this right now).

Also true what @mistydemeo said. Please add the avx stuff if compiler is :clang and the hardware is right. (https://github.com/mxcl/homebrew/blob/master/Library/Homebrew/os/mac/hardware.rb#L27)

And please check if superenv does not remove the avx flags during compiler call.

Contributor

mistydemeo commented Apr 7, 2013

I added a new helper to determine if the CPU is AVX-capable: Hardware::CPU.avx?

You'll still need to ensure that it's only enabled if the compiler is clang.

Contributor

sxprophet commented Apr 8, 2013

@samueljohn and @mistydemeo
Thanks for your comments. I'm closing this PR in favor of new, separated PRs for fftw and gfortran.

@sxprophet sxprophet closed this Apr 8, 2013

Contributor

mistydemeo commented Apr 8, 2013

You can keep them separate by pushing to separate branches on your Github fork of homebrew.

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.