(Does this work correctly for heads on branches?)
It only tries to detect it if :tag is given; haven't given any thought to other cases
I think the CI failure is because the running bot doesn't have the new detection logic, and it loads formula files that then appear to be missing versions, so it should be OK.
Simplify custom version scheme handling
Detect versions in tag specs
Reject versions that aren't strings
@jacknagel The failures look like they are on the "non-executables are installed to bin" (assuming @adamv made those warnings throw a failure like mentioned). The only time it does the different detection logic is if it's outside of running an actual brew foo command and instead inside the brew-test-bot code itself.
Oh sweet, is that everything from this change that installs non-bins?
@mikemcquaid I was looking at an earlier failure: http://bot.brew.sh/job/Homebrew%20Pull%20Requests/380/version=mountain_lion/console
I've since repushed, not sure what the difference is though.
Ah, yes, that looks like a problem. Looking.
This stuff seems to happen enough that I'm reconsidering my "brew-test-bot should always be the master version` approach. Thoughts?
There are pros and cons to both approaches, I guess; I defer to your judgement.