Detect versions in tags #20891

Closed
wants to merge 3 commits into
from

3 participants

@jacknagel

Addresses #18300.

@adamv

Nice.

(Does this work correctly for heads on branches?)

@jacknagel

It only tries to detect it if :tag is given; haven't given any thought to other cases

@jacknagel

I think the CI failure is because the running bot doesn't have the new detection logic, and it loads formula files that then appear to be missing versions, so it should be OK.

@MikeMcQuaid
Homebrew member

@jacknagel The failures look like they are on the "non-executables are installed to bin" (assuming @adamv made those warnings throw a failure like mentioned). The only time it does the different detection logic is if it's outside of running an actual brew foo command and instead inside the brew-test-bot code itself.

@adamv

Oh sweet, is that everything from this change that installs non-bins?

@jacknagel

@mikemcquaid I was looking at an earlier failure: http://bot.brew.sh/job/Homebrew%20Pull%20Requests/380/version=mountain_lion/console

I've since repushed, not sure what the difference is though.

@MikeMcQuaid
Homebrew member

Ah, yes, that looks like a problem. Looking.

@MikeMcQuaid
Homebrew member

This stuff seems to happen enough that I'm reconsidering my "brew-test-bot should always be the master version` approach. Thoughts?

@jacknagel

There are pros and cons to both approaches, I guess; I defer to your judgement.

@jacknagel jacknagel added a commit that closed this pull request Jun 29, 2013
@jacknagel jacknagel Detect versions in tag specs
Closes #18300.
Closes #20891.
a16c80a
@jacknagel jacknagel closed this in a16c80a Jun 29, 2013
@jacknagel jacknagel deleted the unknown repository branch Jun 29, 2013
@handyman5 handyman5 pushed a commit to handyman5/homebrew that referenced this pull request Oct 7, 2013
@jacknagel jacknagel Detect versions in tag specs
Closes #18300.
Closes #20891.
48c99fc
@shelhamer shelhamer added a commit that referenced this pull request Apr 18, 2014
@jacknagel jacknagel Detect versions in tag specs
Closes #18300.
Closes #20891.
0a9b410
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.