carton 0.3.1 #21594

Closed
wants to merge 6 commits into
from

Projects

None yet

4 participants

@MerelyAPseudonym
Contributor

It seems arguable that the Emacs formula should be moved to Dupes. If you agree, then feel free to hold off on creating this formula until Emacs has been migrated.

Also, a plain prefix.install Dir['*'] keeps a lot of junk. Is that a problem? I've included the output of running brew ls carton.

/usr/local/Cellar/carton/0.3.1/bin/carton
/usr/local/Cellar/carton/0.3.1/Carton
/usr/local/Cellar/carton/0.3.1/carton.el
/usr/local/Cellar/carton/0.3.1/carton.png
/usr/local/Cellar/carton/0.3.1/features/projects/.gitignore
/usr/local/Cellar/carton/0.3.1/features/step-definitions/carton-steps.el
/usr/local/Cellar/carton/0.3.1/features/support/env.el
/usr/local/Cellar/carton/0.3.1/features/ (9 files)
/usr/local/Cellar/carton/0.3.1/go
/usr/local/Cellar/carton/0.3.1/Makefile
/usr/local/Cellar/carton/0.3.1/server/ (6 files)
/usr/local/Cellar/carton/0.3.1/templates/ (3 files)
/usr/local/Cellar/carton/0.3.1/test/super/Carton
/usr/local/Cellar/carton/0.3.1/test/ (4 files)

A quick look through the project makes me think that only bin/carton, carton.el, and templates/ are necessary to keep.

@adamv
Contributor
adamv commented Aug 1, 2013

It seems arguable that the Emacs formula should be moved to Dupes.

There is way too much demand for the very newest version of emacs across OS X versions for us to move this to dupes.

@adamv adamv commented on an outdated diff Aug 1, 2013
Library/Formula/carton.rb
@@ -0,0 +1,20 @@
+require 'formula'
+
+class Carton < Formula
+ homepage 'https://github.com/rejeep/carton#readme'
+ head 'git://github.com/rejeep/carton'
+ url 'https://github.com/rejeep/carton/archive/v0.3.1.tar.gz'
+ version '0.3.1'
+ sha1 'd8c76e6db32d319f95bfec1abad4627c144dd9df'
+
+ # `package.el` is only included by default in Emacs >= 24
+ depends_on 'emacs'
@adamv
adamv Aug 1, 2013 Contributor

Use a Requirement for this instead of depending on emacs.

@adamv adamv and 1 other commented on an outdated diff Aug 1, 2013
Library/Formula/carton.rb
@@ -0,0 +1,20 @@
+require 'formula'
+
+class Carton < Formula
+ homepage 'https://github.com/rejeep/carton#readme'
+ head 'git://github.com/rejeep/carton'
+ url 'https://github.com/rejeep/carton/archive/v0.3.1.tar.gz'
+ version '0.3.1'
+ sha1 'd8c76e6db32d319f95bfec1abad4627c144dd9df'
+
+ # `package.el` is only included by default in Emacs >= 24
+ depends_on 'emacs'
+
+ def install
+ prefix.install Dir['*']
@adamv
adamv Aug 1, 2013 Contributor

Please provide a file list of what this installs.

@MerelyAPseudonym
MerelyAPseudonym Aug 1, 2013 Contributor

I'm not exactly sure what you had in mind, but I pushed some changes that might be sufficient.

@adamv adamv and 1 other commented on an outdated diff Aug 1, 2013
Library/Formula/carton.rb
@@ -0,0 +1,20 @@
+require 'formula'
+
+class Carton < Formula
+ homepage 'https://github.com/rejeep/carton#readme'
+ head 'git://github.com/rejeep/carton'
+ url 'https://github.com/rejeep/carton/archive/v0.3.1.tar.gz'
+ version '0.3.1'
@adamv
adamv Aug 1, 2013 Contributor

Please brew audit carton; it should say the version isn't needed.

@MerelyAPseudonym
MerelyAPseudonym Aug 1, 2013 Contributor

Apologies; brew create told me I needed to add one. I guess I'll take a look at that cmd later…

@adamv adamv commented on an outdated diff Aug 1, 2013
Library/Formula/carton.rb
@@ -0,0 +1,20 @@
+require 'formula'
+
+class Carton < Formula
+ homepage 'https://github.com/rejeep/carton#readme'
+ head 'git://github.com/rejeep/carton'
@adamv
adamv Aug 1, 2013 Contributor

By convention, head goes at the end of this block.

@MerelyAPseudonym
Contributor

There is way too much demand for the very newest version of emacs across OS X versions for us to move this to dupes.

No problem.

I totally forgot about brew audit—my bad. I think everything's been fixed. Would you prefer that I squash all of the commits right now? Or do you want to provide feedback before I clean up the history?

@adamv
Contributor
adamv commented Aug 15, 2013

This is now called "cask" and is up to 0.4.5; will need to be updated.

@adamv
Contributor
adamv commented Aug 17, 2013

Will review an updated pull request for cask.

@adamv adamv closed this Aug 17, 2013
@tjnycum
Contributor
tjnycum commented Jun 5, 2015

@adamv

There is way too much demand for the very newest version of emacs across OS X versions for us to move this to dupes.

Would you please elaborate on this? I assume you mean moving it to dupes would inconvenience too many users, but it's not clear to me what the inconvenience would be. Is it the resulting need to tap dupes or would the move somehow break existing installations? (I've had at least one installed formula be moved to x11 and don't recall it causing any trouble.)

@DomT4
Contributor
DomT4 commented Jun 5, 2015

Let's not bump two year old issues - If you'd like an answer on a specific topic the mailing list, IRC or opening a new Github issue is the way to go.

In Emacs case it's the situation that people can feel things of a certain popularity should be available to users without extra hoops to jump through.

@DomT4 DomT4 locked and limited conversation to collaborators Jun 5, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.