This repository has been archived by the owner. It is now read-only.

rdesktop 1.8.0 #22116

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

feuvan commented Aug 25, 2013

use system openssl path explicitly in case cmake fails.
experimental 10.9 support.
dropped previous pr #22112

rdesktop 1.8.0
use system openssl path explicitly in case cmake fails.
experimental 10.9 support.
Contributor

adamv commented Aug 25, 2013

Maintainers: it looks like this also includes Mavericks fixes; do we want to slice them out of the version update?

- system "./configure", "--disable-debug",
- "--prefix=#{prefix}"
+ args = ["--prefix=#{prefix}", "--disable-credssp", "--disable-smartcard", "--with-openssl=#{MacOS.sdk_path}/usr"]
+ args << "--x-includes=/opt/X11/include" if MacOS.version >= :mavericks
@jacknagel

jacknagel Aug 25, 2013

Contributor

This should be --x-includes=#{MacOS::X11.include}, (and thus doesn't need to be conditional)

Contributor

jacknagel commented Aug 25, 2013

Has the patch been submitted upstream?

Contributor

adamv commented Aug 28, 2013

Ping.

Contributor

feuvan commented Aug 28, 2013

reported on dev mailing list http://sourceforge.net/mailarchive/message.php?msg_id=31339514
Do you want me to change to "--x-includes=#{MacOS::X11.include}" and send another pull request?

Contributor

adamv commented Aug 28, 2013

Yes please, and include that link in a comment

@feuvan feuvan referenced this pull request Aug 28, 2013

Closed

rdesktop 1.8.0 #22178

@feuvan feuvan closed this Aug 28, 2013

@feuvan feuvan deleted the feuvan:rdesktop1.8.0 branch Aug 28, 2013

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 17, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.