open-scene-graph:Added support for qt5 (standard) and qt (fallback). #22283

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@Kelloggs
Contributor
Kelloggs commented Sep 3, 2013

No description provided.

@adamv adamv commented on the diff Sep 10, 2013
Library/Formula/open-scene-graph.rb
@@ -49,6 +51,12 @@ def install
args << "-DCOLLADA_INCLUDE_DIR=#{HOMEBREW_PREFIX}/include/collada-dom"
end
+ if Formula.factory('qt5').installed?
+ args << "-DCMAKE_PREFIX_PATH=#{HOMEBREW_PREFIX}/opt/qt5"
adamv
adamv Sep 10, 2013 Contributor

Use Formula.factory('qt5').opt_prefix...

@adamv adamv commented on the diff Sep 10, 2013
Library/Formula/open-scene-graph.rb
@@ -49,6 +51,12 @@ def install
args << "-DCOLLADA_INCLUDE_DIR=#{HOMEBREW_PREFIX}/include/collada-dom"
end
+ if Formula.factory('qt5').installed?
+ args << "-DCMAKE_PREFIX_PATH=#{HOMEBREW_PREFIX}/opt/qt5"
+ elsif Formula.factory('qt').installed?
+ args << "-DCMAKE_PREFIX_PATH=#{HOMEBREW_PREFIX}/opt/qt"
adamv
adamv Sep 10, 2013 Contributor

...and similar here.

Contributor
adamv commented Sep 10, 2013

Instead of using installation checks, explicitly check that the build flag created by => :optional was specified.

Contributor
adamv commented Sep 14, 2013

Ping.

Pong.

Contributor
adamv commented Sep 20, 2013

There are some comments in the code review waiting for responses.

Contributor

Closing due to no response

@jacknagel jacknagel closed this Nov 28, 2013
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.