plt-racket 5.3.6 #22420

Closed
wants to merge 1 commit into
from

Projects

None yet

8 participants

@MerelyAPseudonym
Contributor

Assuming all goes well, I believe this patch subsumes #17901

@MerelyAPseudonym
Contributor

There's more that could be done to clean up the installation of Racket, but I'm not sure it's worth the time. This current incarnation of the formula works for me (and we'll soon see if it works for the brew test bot), plus Racket has been reorganized to make building & installing quicker and more flexible. So presumably once 5.4.0 (or 6.0.0? I dunno) comes out, it'll be worthwhile to consider the ideal formula.

@MerelyAPseudonym
Contributor

I saw the failure and am trying out an installation on a Lion machine I have.

@MerelyAPseudonym
Contributor

It looks like it has to do being unable to find libcairo on versions of OS X before Mountain Lion. I'm not sure how to handle it, given that cairo is declared as a dependency. Any advice?

@MerelyAPseudonym
Contributor

On my Lion machine, running the following two commands made Racket 5.3.6 build successfully:

  • brew link --force cairo
  • brew link --force libpng

Does that give any direction regarding what a proper solution would look like?

@nixpulvis

For what it's worth, this PR is working for me on ML. I know you tested that I thought I'd confirm I'm up without issues.

@adamv
Contributor
adamv commented Sep 10, 2013

@MerelyAPseudonym that helps; presumably the dlopen call will have no way of knowing where to find the non-standard cairo

@nixpulvis
> (require 2htdp/universe)
ffi-lib: couldn't open "libgdk-x11-2.0.0.dylib" (dlopen(libgdk-x11-2.0.0.dylib, 6): image not found)

Actually I am getting some issues I don't get from the downloaded package.

@MerelyAPseudonym
Contributor

@nixpulvis If you brew install gtk (I dunno if the with-jasper option matters here), then do you still get your problem?

@nixpulvis

brew install --with-jasper gtk made it work now. I'm not sure exactly what (if anything) --with-jasper does.

@adamv adamv referenced this pull request Sep 10, 2013
Closed

Racket 5.3.3 #17901

@adamv
Contributor
adamv commented Sep 14, 2013

@MerelyAPseudonym can you add a gtk dependency and re-push?

@nixpulvis

I'm completely unsure how the brew test server works, but it might be worth looking into a way to add a test to ensure this doesn't slip through. Currently installing without gtk passes tests on ML.

@MikeMcQuaid
Member

Add a test do block and the test server will run it.

@MerelyAPseudonym
Contributor

Hey guys,
I was uncomfortable with forcing people to link cairo and libpng (and who knows what else more), so I looked into a way to replicate some effects of the reorganization in Racket's HEAD and only build select "core" modules. (Cf. https://github.com/plt/racket/tree/f5b82eb510c02bb512cc6a8c4dfcb7c16efe6657/racket/collects)

I figured out how to do it, but it requires two small changes in the source code. I'm in the middle of creating an issue over at the Racket repo because I think those changes are only necessary because of a minor bug.

@nixpulvis

What will this mean for additional functionality?

@MerelyAPseudonym
Contributor

Right now I'm envisioning a sorta --with-full-distro option that would have the all of the GUI-related dependencies like gtk and cairo.

That said, you should be able to take a minimal Racket installation and run with it, adding whatever packages you need with raco planet install $DESIRED_PKG. Kinda like just using ghc and cabal-install rather than using the full haskell-platform.

But it seems like getting the minimal installation working is a good first step because it'll let us isolate variables. Plus, the Racket guys already provide downloadable, pre-compiled versions of "full Racket": http://racket-lang.org/download/

@nixpulvis

Sounds solid.

@adamv
Contributor
adamv commented Sep 18, 2013

Let us know when to pull this.

@adamv
Contributor
adamv commented Sep 23, 2013

This is passing brew-bot, should we pull or do you want to do more work on it? I ask since the last commit is labeled "WIP".

@MerelyAPseudonym
Contributor

@adamv I do want to do more work on it, but it probably won't be until this weekend. How about I'll describe what else I want to improve; if you guys are okay with all of the items happening later, then I'll squash the existing commits and you can pull immediately.

To Do

  • Get the blessing/approval from someone on the PLT Racket team that I've inferred a reasonable subset as the "base" Racket packages.
  • The current version of the formula (i.e., my WIP version) still retains the source files of every package even though we only install that limited subset of them. I need to decide if this is a problem and, if it is, how to strain out these files.
  • Provide a --with-docs option to the formula (which I believe requires cairo)
  • Figure out how to add search paths to a Racket installation so that post-build Racket will be able to find Homebrew's gtk, Homebrew's pango, etc.
  • Provide a --with-graphics-libs option that would enable the user to run anything she found in How to Design Programs and Realm of Racket. I suppose providing a --with-full-distro option would subsume this though…
@adamv
Contributor
adamv commented Sep 27, 2013

I can wait, no rush.

@jdavis
jdavis commented Sep 28, 2013

This looks great. Let me know if there's anything you need help with, @MerelyAPseudonym.

@nixpulvis

Agreed, It'll be nice to have a consistent way to install Racket on the mac without DrRacket.

@jdavis
jdavis commented Sep 28, 2013

Well right now you can install version 5.2 of Racket with brew install pl-racket. I'm just excited for 5.3.6 since it's the latest.

@MerelyAPseudonym
Contributor

I finally finished reporting the bug to the Racket peeps, so keeping my patch in the formula should be kosher.

I also finally sought a PLT blessing on my strategy to create a minimal Racket installation: http://lists.racket-lang.org/users/archive/2013-October/060089.html

I also ALSO started making some progress on figuring out how to make things like Cairo visible to Racket: http://lists.racket-lang.org/users/archive/2013-October/060024.html

If nothing terrible happens, I'll squash the commits in the next few days to make this thing merge-able.

@adamv
Contributor
adamv commented Nov 5, 2013

Ready to go yet?

@arnab
arnab commented Nov 5, 2013

Excited to see this. FWIW, this installed fine on my 10.9 system:

$  ~  brew install https://raw.github.com/MerelyAPseudonym/homebrew/60a8ffb32b85dfac9987f5e2df3f17ad388114f5/Library/Formula/plt-racket.rb
######################################################################## 100.0%
==> Downloading https://github.com/plt/racket/archive/v5.3.6.tar.gz
######################################################################## 100.0%
==> Patching
patching file src/Makefile.in
==> ./configure --enable-xonx --prefix=/usr/local/Cellar/plt-racket/5.3.6 --disable-gracket --disable-docs
==> make
==> Installing may take a long time (~60 minutes)
==> make install
/usr/local/Cellar/plt-racket/5.3.6: 11638 files, 125M, built in 5.6 minutes

$  ~  racket -v
Welcome to Racket v5.3.6.

$  ~  racket
Welcome to Racket v5.3.6.
> (+ 1 2)
3

More details on the system:

$  ~  brew --config
HOMEBREW_VERSION: 0.9.5
ORIGIN: https://github.com/mxcl/homebrew
HEAD: 83234d9ceb6c88592dd3bb4848e31b59d3da81eb
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CELLAR: /usr/local/Cellar
CPU: 8-core 64-bit ivybridge
OS X: 10.9-x86_64
Xcode: 5.0.1
CLT: 5.0.1.0.1.1382131676
GCC-4.2: build 5666
Clang: 5.0 build 500
X11: 2.7.4 => /opt/X11
System Ruby: 1.8.7-358
Perl: /usr/bin/perl
Python: /usr/local/bin/python => /usr/local/Cellar/python/2.7.3/Frameworks/Python.framework/Versions/2.7/bin/python2.7
Ruby: /usr/local/opt/rbenv/shims/ruby => /usr/local/Cellar/rbenv/0.4.0/shims/ruby
@MikeMcQuaid MikeMcQuaid and 1 other commented on an outdated diff Nov 5, 2013
Library/Formula/plt-racket.rb
system "make install"
end
end
end
+
+__END__
+diff --git a/src/Makefile.in b/src/Makefile.in
+index ce4bac4..5d12d25 100644
+--- a/src/Makefile.in
++++ b/src/Makefile.in
+@@ -62,7 +62,7 @@ both:
+
+ # Install (common) ----------------------------------------
+
+-SETUP_ARGS = -X @DIRCVTPRE@"$(DESTDIR)$(collectsdir)"@DIRCVTPOST@ -N "raco setup" -l- setup $(PLT_SETUP_OPTIONS) $(PLT_ISO) @INSTALL_SETUP_FLAGS@
++SETUP_ARGS = -X @DIRCVTPRE@"$(DESTDIR)$(collectsdir)"@DIRCVTPOST@ -N "raco setup" -l- setup $(PLT_ISO) @INSTALL_SETUP_FLAGS@ $(PLT_SETUP_OPTIONS)
@MikeMcQuaid
MikeMcQuaid Nov 5, 2013 Member

Has this been submitted upstream?

@MikeMcQuaid MikeMcQuaid commented on an outdated diff Nov 5, 2013
Library/Formula/plt-racket.rb
system "./configure", *args
system "make"
- ohai "Installing may take a long time (~40 minutes)" unless ARGV.verbose?
+ ohai "Installing may take a long time (~60 minutes)" unless ARGV.verbose?
@MikeMcQuaid
MikeMcQuaid Nov 5, 2013 Member

Just remove this line; we don't do this for other formulae.

@MikeMcQuaid MikeMcQuaid commented on an outdated diff Nov 5, 2013
Library/Formula/plt-racket.rb
+ ENV['PLT_SETUP_OPTIONS'] = '--workers 1 -l compiler data db dynext ffi file json launcher net openssl pkg planet racket raco reader s-exp setup syntax unstable version xml'
@MikeMcQuaid
MikeMcQuaid Nov 5, 2013 Member

Wrap to 80 characters.

@MikeMcQuaid MikeMcQuaid commented on an outdated diff Nov 5, 2013
Library/Formula/plt-racket.rb
def install
cd 'src' do
- args = ["--disable-debug", "--disable-dependency-tracking",
- "--enable-xonx",
- "--enable-shared",
- "--prefix=#{prefix}" ]
-
- if MacOS.prefer_64_bit?
- args += ["--enable-mac64", "--enable-sgc", "--disable-gracket"]
- end
+ args = %W[ --disable-debug --disable-dependency-tracking
+ --enable-xonx
+ --prefix=#{prefix}
+ --disable-gracket
+ --disable-docs ]
@MikeMcQuaid
MikeMcQuaid Nov 5, 2013 Member

Please just use the same array format as before.

@MikeMcQuaid MikeMcQuaid and 1 other commented on an outdated diff Nov 5, 2013
Library/Formula/plt-racket.rb
@@ -2,26 +2,44 @@
class PltRacket < Formula
homepage 'http://racket-lang.org/'
- # Use GitHub tarball as the release tarball doesn't have
- # everything needed for building on OS X
- url 'https://github.com/plt/racket/archive/v5.2.tar.gz'
- sha1 '313425909ff8d956c3e99d0a2b5b3cb12d0f98ad'
+ url 'https://github.com/plt/racket/archive/v5.3.6.tar.gz'
+ sha256 'aa33ff303a8b7f7fed28a1d78e0a38760c1fe33faf7a1d365ee1ba7d3da1ec11'
@MerelyAPseudonym
MerelyAPseudonym Nov 30, 2013 Contributor

Um... because I had assumed more is better?

I'll use sha1 in the cleaned up version (which I'll push in a few minutes)

@MikeMcQuaid
Member

Few nitpicks. For future reference please don't change the style of existing formula code unless it's necessary and related to the version update; it makes the diff much harder to follow.

@dch
Contributor
dch commented Nov 10, 2013

Works for me - tyvm!!

nitpicks: whitespace in the diff is a bit wonky too. +1 for @mikemcquaid's point.

FWIW on aging my feb 2011 mbp,

==> Summary
/usr/local/Cellar/plt-racket/5.3.6: 11638 files, 125M, built in 5.0 minutes
brew install -v plt-racket 499,11s user 47,46s system 180% cpu 5:02,26 total

That's not too bad.

@adamv
Contributor
adamv commented Nov 17, 2013

Ping.

@MerelyAPseudonym
Contributor

I heard back from the Racket devs regarding my remaining questions. I'll
wrap this up tomorrow.

On Saturday, November 16, 2013, Adam Vandenberg wrote:

Ping.


Reply to this email directly or view it on GitHubhttps://github.com/mxcl/homebrew/pull/22420#issuecomment-28642641
.

@MerelyAPseudonym
Contributor

I abandoned the "minimal racket" attempt at the advice of a Racket developer: http://www.mail-archive.com/users@racket-lang.org/msg20111.html.

If the Homebrew team is OK with the current state of this pull request, I'd say it's OK to merge.

@adamv
Contributor
adamv commented Nov 30, 2013

Error: undefined methodprefer_32_bit?' for OS::Mac:Module`

@MerelyAPseudonym
Contributor

@adamv yeah, I just saw that too. I'm mildly embarrassed I left that "wishful thinking" method in. I'm fixing it right now.

@adamv adamv and 1 other commented on an outdated diff Nov 30, 2013
Library/Formula/plt-racket.rb
"--prefix=#{prefix}" ]
- if MacOS.prefer_64_bit?
- args += ["--enable-mac64", "--enable-sgc", "--disable-gracket"]
- end
+ MacOS.prefer_64_bit? || args << '--disable-mac64'
@adamv
adamv Nov 30, 2013 Contributor

Please use an if statement rather than ||; this isn't bash (or perl).

@MerelyAPseudonym
MerelyAPseudonym Nov 30, 2013 Contributor

No problem. Fixed to use unless. Lemme know if you'd prefer if ! or if not.

@adamv adamv and 1 other commented on an outdated diff Nov 30, 2013
Library/Formula/plt-racket.rb
system "make install"
end
end
+
+ test do
+ system 'racket', '--eval', '(require 2htdp/universe)'
@adamv
adamv Nov 30, 2013 Contributor

Need full path to binary under test: system bin/'racket', ...

@MerelyAPseudonym
MerelyAPseudonym Nov 30, 2013 Contributor

Thanks. Fixing it.

@adamv
Contributor
adamv commented Nov 30, 2013

Showing build failures on brew-bot

@MerelyAPseudonym
Contributor

Weird. The Racket build downloads some dynamic libraries from racket-lang.org if it can't find them. That smelled to me, but I figured I could bother with refining that stuff later.

@adamv
Contributor
adamv commented Nov 30, 2013

I'll try locally if I get a chance.

@MerelyAPseudonym
Contributor

ohhhh, I think I just figured it out: the Racket build will attempt to download the dependencies it needs if it's creating independent packages for OS X or Windows. I.e., by including the --enable-xonx switch, we effectively disable the auto-downloading.

I'll just add the dependencies from a previous version of the pull request back in.

@MerelyAPseudonym
Contributor

I just saw the brew audit plt-racket note about how I should use gtk+ instead of gtk. I'll fix that after brew-test-bot completes because I want to see the results for Lion & Mountain Lion.

@adamv
Contributor
adamv commented Dec 1, 2013

Thanks for sticking it out, this is really a huge help to us.

@MerelyAPseudonym
Contributor

@adamv =) well, the encouragement helps.

I think the Lion & Mountain Lion builds will be fixed by deparallelizing the build, but I don't know what to make of the Mavericks error.

@adamv
Contributor
adamv commented Dec 1, 2013

Since the 10.9 failure is in the tests I'm not too concerned, but probably it is expect there to be an actual display (which there isn't.)

@MerelyAPseudonym
Contributor

That's almost certainly the problem. Is it worth me changing system bin/'racket', '--eval', '(require 2htdp/universe)' to the following?

# Make sure all of the GUI-related dynamic libraries are available.
system bin/'racket', '--eval', '(require ffi/unsafe) (or (ffi-lib "libcairo") (exit 1))'
system bin/'racket', '--eval', '(require ffi/unsafe) (or (ffi-lib "libffi") (exit 1))'
# checking for libintl seems tricky, so I'd ignore that
system bin/'racket', '--eval', '(require ffi/unsafe) (or (ffi-lib "libgio-2.0") (exit 1))'
system bin/'racket', '--eval', '(require ffi/unsafe) (or (ffi-lib "libjpeg") (exit 1))'
system bin/'racket', '--eval', '(require ffi/unsafe) (or (ffi-lib "libglib-2.0") (exit 1))'
system bin/'racket', '--eval', '(require ffi/unsafe) (or (ffi-lib "libpango-1.0") (exit 1))'
system bin/'racket', '--eval', '(require ffi/unsafe) (or (ffi-lib "libgmodule-2.0") (exit 1))'
system bin/'racket', '--eval', '(require ffi/unsafe) (or (ffi-lib "libpangocairo-1.0") (exit 1))'
system bin/'racket', '--eval', '(require ffi/unsafe) (or (ffi-lib "libgobject-2.0") (exit 1))'
system bin/'racket', '--eval', '(require ffi/unsafe) (or (ffi-lib "libpixman-1") (exit 1))'
system bin/'racket', '--eval', '(require ffi/unsafe) (or (ffi-lib "libgthread-2.0") (exit 1))'
system bin/'racket', '--eval', '(require ffi/unsafe) (or (ffi-lib "libpng15") (exit 1))'

By the way, I got the list of runtime dependencies from https://github.com/plt/racket/blob/ded0c4a8474baa61ac84fb27dfb5353965fb756b/src/get-libs.rkt

@adamv
Contributor
adamv commented Dec 1, 2013

The test block should not have any GUI-requiring bits per policy (to make the brew bot happy)

@MerelyAPseudonym
Contributor

I've fixed everything I know how to; I'm stumped on the Cairo error on Lion (and presumably on Snow Leopard too).

Does anyone have any ideas?

@mistydemeo
Contributor

10.7 still included X11, and if memory serves that still included an older cairo. Possibly it pulls in our cairo in in configure, but then looks for it in the X11 path (or vice versa)?

@MerelyAPseudonym
Contributor

Thanks @mistydemeo, that sounds very plausible. Do you have any suggestions regarding how might I test that? If you're right, is there a canonically correct way to account for that possibility?

@mistydemeo
Contributor

Does the configure script have a way for us to unambiguously specify which cairo to use, or does it respect environment variables? Might work better if we tell it to use the exact cairo we want.

@mistydemeo mistydemeo commented on an outdated diff Dec 2, 2013
Library/Formula/plt-racket.rb
@@ -2,26 +2,64 @@
class PltRacket < Formula
homepage 'http://racket-lang.org/'
- # Use GitHub tarball as the release tarball doesn't have
- # everything needed for building on OS X
- url 'https://github.com/plt/racket/archive/v5.2.tar.gz'
- sha1 '313425909ff8d956c3e99d0a2b5b3cb12d0f98ad'
+ url 'https://github.com/plt/racket/archive/v5.3.6.tar.gz'
+ sha1 '6b0e7a11bb3ae6480b99db346e5b503a97539e6b'
+
+ depends_on 'glib'
+ depends_on 'cairo' if MacOS.version >= :mountain_lion
@mistydemeo
mistydemeo Dec 2, 2013 Contributor

Unfortunately the other deps will still be built against the Homebrew cairo, and linking against both is likely to cause problems.

@MerelyAPseudonym
Contributor

@mistydemeo, it looks like it respects environment variables... Would we be tweaking LIBS or LDFLAGS?

I've provided the output of ./configure --help below.

`configure' configures this package to adapt to many kinds of systems.

Usage: ./configure [OPTION]... [VAR=VALUE]...

To assign environment variables (e.g., CC, CFLAGS...), specify them as
VAR=VALUE.  See below for descriptions of some of the useful variables.

Defaults for the options are specified in brackets.

Configuration:
  -h, --help              display this help and exit
      --help=short        display options specific to this package
      --help=recursive    display the short help of all the included packages
  -V, --version           display version information and exit
  -q, --quiet, --silent   do not print `checking...' messages
      --cache-file=FILE   cache test results in FILE [disabled]
  -C, --config-cache      alias for `--cache-file=config.cache'
  -n, --no-create         do not create output files
      --srcdir=DIR        find the sources in DIR [configure dir or `..']

Installation directories:
  --prefix=PREFIX         install architecture-independent files in PREFIX
              [/usr/local]
  --exec-prefix=EPREFIX   install architecture-dependent files in EPREFIX
              [PREFIX]

By default, `make install' will install all the files in
`/usr/local/bin', `/usr/local/lib' etc.  You can specify
an installation prefix other than `/usr/local' using `--prefix',
for instance `--prefix=$HOME'.

For better control, use the options below.

Fine tuning of the installation directories:
  --bindir=DIR           user executables [EPREFIX/bin]
  --libdir=DIR           object code libraries [EPREFIX/lib]
  --includedir=DIR       C header files [PREFIX/include]
  --datarootdir=DIR      read-only arch.-independent data root [PREFIX/share]
  --datadir=DIR          read-only architecture-independent data [DATAROOTDIR]
  --mandir=DIR           man documentation [DATAROOTDIR/man]
  --docdir=DIR           documentation root [DATAROOTDIR/doc/PACKAGE]

System types:
  --build=BUILD     configure for building on BUILD [guessed]
  --host=HOST       cross-compile to build programs to run on HOST [BUILD]
  --target=TARGET   configure for building compilers for TARGET [HOST]

Optional Features:
  --disable-FEATURE       do not include FEATURE (same as --enable-FEATURE=no)
  --enable-FEATURE[=ARG]  include FEATURE [ARG=yes]
  --enable-gracket        build GRacket as well as Racket (enabled by default)
  --enable-jit            support JIT compiler (enabled by default)
  --enable-foreign        support foreign calls (enabled by default)
  --enable-places         support places (3m only; usually enabled by default)
  --enable-futures        support futures (usually enabled by default)
  --enable-float          support single-precision floats (enabled by default)
  --enable-floatinstead   use single-precision by default (NOT RECOMMENDED)
  --enable-extflonum      support extflonums (enabled by default, if available)
  --enable-racket=<path>  use <path> as Racket executable to build Racket
  --enable-origtree       install with original directory structure
  --enable-pkgscope=<s>   set `raco pkg' default: installation, user, or shared
  --enable-docs           build docs on install (enabled by default)
  --enable-usersetup      setup user-specific files on install
  --enable-shared         create shared libraries (ok, but not recommended)
  --enable-dynlib         same as --enable-shared
  --enable-lt=<prog>      use <prog> instead of libtool; disable to use bundled
  --enable-libffi         use installed libffi (enabled by default for Unix)
  --enable-sdk=<path>     use Mac OS X 10.4 SDK directory
  --enable-xonx           use Unix style (e.g., use Gtk) for Mac OS X
  --enable-libfw          install Mac OS X frameworks to /Library/Frameworks
  --enable-userfw         install Mac OS X frameworks to ~/Library/Frameworks
  --enable-macprefix      allow --prefix with a Mac OS X install
  --enable-mac64          allow 64-bit Mac OS X build (enabled by default)
  --enable-cgcdefault     use CGC as default build (NOT RECOMMENDED)
  --enable-sgc            use Senora GC instead of the Boehm GC
  --enable-sgcdebug       use Senora GC for debugging
  --enable-backtrace      3m: support GC backtrace dumps (expensive debug mode)
  --enable-pthread        link with pthreads (usually auto-enabled if needed)
  --enable-stackup        assume "up" if stack direction cannot be determined
  --enable-bigendian      assume "big" if endianness cannot be determined
  --enable-gprof          compile for profiling with gprof (gcc only)
  --enable-gcov           compile to gather gcov statistics (gcc3 only)
  --enable-noopt          drop -O C flags (useful for low-level debugging)

Some influential environment variables:
  CC          C compiler command
  CFLAGS      C compiler flags
  LDFLAGS     linker flags, e.g. -L<lib dir> if you have libraries in a
              nonstandard directory <lib dir>
  LIBS        libraries to pass to the linker, e.g. -l<library>
  CPPFLAGS    C/C++/Objective C preprocessor flags, e.g. -I<include dir> if
              you have headers in a nonstandard directory <include dir>
  CPP         C preprocessor

Use these variables to override the choices made by `configure' or to help
it to find libraries and programs with nonstandard names/locations.

@mistydemeo
Contributor

Homebrew already sets LDFLAGS appropriately, and LIBS isnt' needed here.

@MerelyAPseudonym
Contributor

In that case, I'm not sure how to tell configure the precise cairo that we want to use.

@adamv adamv referenced this pull request Dec 3, 2013
Closed

update plt-racket to 5.3.6 #24888

@MerelyAPseudonym
Contributor

I just realized that there's a chance that the build will prefer any library in the local lib directory. Like, we might be able to "inject" the intended Cairo by creating a symlink, /tmp/plt-racket-123whatev/lib/libcairo.2.dylib -> /usr/X11/libcairo.2.dylib.

I can try that when I get a chance, but I'd also like to throw out the possibility of just putting in a (hopefully temporary) "must have Mountain Lion or Mavericks" dependency in the formula. Any opinions?

@adamv
Contributor
adamv commented Dec 18, 2013

Willing to take a depends_on :macos => :mountain_lion for now if everything else works correctly.

@nixpulvis

This has been open for a long time. I'd love to see things getting wrapped up too.

@MerelyAPseudonym
Contributor

@adamv, @nixpulvis, thanks. I'll clean up & squash the commits then.

And some good news: the Racket devs are testing/preparing a version 6 release, so hopefully we'll be able to remove the Mountain Lion restriction before too long.

@MerelyAPseudonym MerelyAPseudonym plt-racket 5.3.6
Sometime between versions 5.2 and 5.3.6, `configure` began defaulting
to 64-bit.

Remove the `--enable-shared` configuration because PLT discourages it
and I'm not sure what it gives us.
8926404
@MerelyAPseudonym
Contributor

By the way, any final style nits would not be unwelcome.

@MerelyAPseudonym
Contributor

As far as I can tell, this is good to go.

@adamv adamv added a commit that closed this pull request Dec 19, 2013
@MerelyAPseudonym @adamv MerelyAPseudonym + adamv plt-racket 5.3.6
Closes #22420.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
b3f2793
@adamv adamv closed this in b3f2793 Dec 19, 2013
@ehershey ehershey added a commit to ehershey/homebrew that referenced this pull request Apr 4, 2014
@MerelyAPseudonym @ehershey MerelyAPseudonym + ehershey plt-racket 5.3.6
Closes #22420.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
224536e
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.