libcanberra 0.30 #22853

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@adammw

New formula.

Update from #15021.

@adamv adamv commented on an outdated diff Sep 26, 2013
Library/Formula/libcanberra.rb
+
+ head 'git://git.0pointer.de/libcanberra'
+
+ depends_on 'pkg-config' => :build
+ depends_on 'xz' => :build
+
+ depends_on 'libvorbis'
+
+ depends_on 'pulseaudio' => :optional
+ depends_on 'gstreamer' => :optional
+ depends_on 'gtk+' => :optional
+ depends_on 'gtk+3' => :optional
+
+ def install
+ system "./autogen.sh" if ARGV.build_head?
+
@adamv
adamv Sep 26, 2013

Remove newline

@adamv adamv commented on an outdated diff Sep 26, 2013
Library/Formula/libcanberra.rb
+
+ depends_on 'pkg-config' => :build
+ depends_on 'xz' => :build
+
+ depends_on 'libvorbis'
+
+ depends_on 'pulseaudio' => :optional
+ depends_on 'gstreamer' => :optional
+ depends_on 'gtk+' => :optional
+ depends_on 'gtk+3' => :optional
+
+ def install
+ system "./autogen.sh" if ARGV.build_head?
+
+ system "./configure", "--prefix=#{prefix}"
+
@adamv
adamv Sep 26, 2013

Remove newline

@adamv adamv commented on an outdated diff Sep 26, 2013
Library/Formula/libcanberra.rb
+ depends_on 'libvorbis'
+
+ depends_on 'pulseaudio' => :optional
+ depends_on 'gstreamer' => :optional
+ depends_on 'gtk+' => :optional
+ depends_on 'gtk+3' => :optional
+
+ def install
+ system "./autogen.sh" if ARGV.build_head?
+
+ system "./configure", "--prefix=#{prefix}"
+
+ system "make install"
+ end
+
+ def patches
@adamv
adamv Sep 26, 2013

def patches should come before def install

@adamv adamv commented on an outdated diff Sep 26, 2013
Library/Formula/libcanberra.rb
+ sha1 'fd4c16e341ffc456d688ed3462930d17ca6f6c20'
+
+ head 'git://git.0pointer.de/libcanberra'
+
+ depends_on 'pkg-config' => :build
+ depends_on 'xz' => :build
+
+ depends_on 'libvorbis'
+
+ depends_on 'pulseaudio' => :optional
+ depends_on 'gstreamer' => :optional
+ depends_on 'gtk+' => :optional
+ depends_on 'gtk+3' => :optional
+
+ def install
+ system "./autogen.sh" if ARGV.build_head?
@adamv
adamv Sep 26, 2013

Use if build.head?

@asparagui
Homebrew member

looks like you're gonna need:

depends_on :libltdl

@adamv

Ping.

@adamv

@BrewTestBot test this please

@adamv

We haven't pulled pulseaudio yet

@asparagui
Homebrew member

he was working on pulse as well: #22846

@adamv

The libtool and intltool deps need to be sorted out over there.

@adammw

sorry guys, i won't be able to update this for a couple of weeks yet, busy with exams.

@adamv

No rush!

@adamv

Any update here?

@adammw

I was planning on getting the pulseaudio formula working and committed before attempting this one which depends_on pulseaudio. I'm getting a weird error with the compiled binaries and I'm not sure how to fix it.

@adamv

A working pulseaudio formula has been added.

@adamv adamv added a commit that closed this pull request Apr 19, 2014
@adammw adammw libcanberra 0.30
Closes #22853.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
83a8452
@adamv adamv closed this in 83a8452 Apr 19, 2014
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.