This repository has been archived by the owner. It is now read-only.

Backport Emacs HEAD's fullscreen mode option #23729

Closed
wants to merge 1 commit into
base: master
from

Conversation

5 participants
@scotchi
Contributor

scotchi commented Oct 29, 2013

This makes it possible to bypass OS X's fullscreen mode. The changes
were pulled from Emacs's bzr repository with minimal changes to get
them to work with 24.3

This resolves the issues folks had (e.g. #15448) with the now exclusive use of OS X's fullscreen and makes it possible to get behavior similar to the behavior back when homebrew included a fullscreen patch.

And again, this is stuff coming down the pipe from upstream anyway. This just pulls in the current configurable behavior from their repo. With this patch applied you can switch to the old fullscreen behavior by setting:

(setq ns-use-native-fullscreen nil)
@jinn8522

This comment has been minimized.

Show comment
Hide comment
@jinn8522

jinn8522 Nov 5, 2013

Wonderful work.thanks for your work

jinn8522 commented Nov 5, 2013

Wonderful work.thanks for your work

@ghost ghost assigned adamv Nov 5, 2013

@adamv

This comment has been minimized.

Show comment
Hide comment
@adamv

adamv Nov 5, 2013

Contributor

@MikeMcQuaid any objection to me pulling this?

Contributor

adamv commented Nov 5, 2013

@MikeMcQuaid any objection to me pulling this?

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Nov 6, 2013

Member

@adamv If you want it, sure. I'd rather we waited given it required "minimal changes" that could break other things.

Member

MikeMcQuaid commented Nov 6, 2013

@adamv If you want it, sure. I'd rather we waited given it required "minimal changes" that could break other things.

@adamv

This comment has been minimized.

Show comment
Hide comment
@adamv

adamv Nov 6, 2013

Contributor

@MikeMcQuaid I don't use this feature myself, no

Contributor

adamv commented Nov 6, 2013

@MikeMcQuaid I don't use this feature myself, no

@adamv

This comment has been minimized.

Show comment
Hide comment
@adamv

adamv Nov 6, 2013

Contributor

Since this patch is based on upstream, I want to pull it in since it is a widely requested feature.

@scotchi can you rebase on the current emacs formula?

Contributor

adamv commented Nov 6, 2013

Since this patch is based on upstream, I want to pull it in since it is a widely requested feature.

@scotchi can you rebase on the current emacs formula?

Backport Emacs HEAD's fullscreen mode option
This makes it possible to bypass OS X's fullscreen mode.  The changes
were pulled from Emacs's bzr repository with minimal changes to get
them to work with 24.3
@scotchi

This comment has been minimized.

Show comment
Hide comment
@scotchi

scotchi Nov 6, 2013

Contributor

Ok, I reworked the commit against the current homebrew master.

Contributor

scotchi commented Nov 6, 2013

Ok, I reworked the commit against the current homebrew master.

@scotchi

This comment has been minimized.

Show comment
Hide comment
@scotchi

scotchi Nov 6, 2013

Contributor

Oh, and for the record, there was no original code that I had to rework for this -- it was just a matter of moving a couple of blocks around to a slightly different place in the file where diff wasn't smart enough to make them apply cleanly.

Contributor

scotchi commented Nov 6, 2013

Oh, and for the record, there was no original code that I had to rework for this -- it was just a matter of moving a couple of blocks around to a slightly different place in the file where diff wasn't smart enough to make them apply cleanly.

@adamv

This comment has been minimized.

Show comment
Hide comment
@adamv

adamv Nov 7, 2013

Contributor

"rework" was too strong a word perhaps, I just meant "rebase".

Contributor

adamv commented Nov 7, 2013

"rework" was too strong a word perhaps, I just meant "rebase".

@adamv adamv closed this in b9d7a7a Nov 7, 2013

yriveiro added a commit to yriveiro/homebrew that referenced this pull request Nov 26, 2013

emacs: backport fullscreen mode from HEAD
This makes it possible to bypass OS X's fullscreen mode.  The changes
were pulled from Emacs's bzr repository with minimal changes to get
them to work with 24.3

Closes #23729.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
@dandavison

This comment has been minimized.

Show comment
Hide comment
@dandavison

dandavison Dec 5, 2013

@scotchi Thanks very much, much appreciated! 🎆

dandavison commented Dec 5, 2013

@scotchi Thanks very much, much appreciated! 🎆

ehershey added a commit to ehershey/homebrew that referenced this pull request Apr 4, 2014

emacs: backport fullscreen mode from HEAD
This makes it possible to bypass OS X's fullscreen mode.  The changes
were pulled from Emacs's bzr repository with minimal changes to get
them to work with 24.3

Closes #23729.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>

@Homebrew Homebrew locked and limited conversation to collaborators Feb 17, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.