Backport Emacs HEAD's fullscreen mode option #23729

Closed
wants to merge 1 commit into
from

Projects

None yet

5 participants

@scotchi
Contributor
scotchi commented Oct 29, 2013

This makes it possible to bypass OS X's fullscreen mode. The changes
were pulled from Emacs's bzr repository with minimal changes to get
them to work with 24.3

This resolves the issues folks had (e.g. #15448) with the now exclusive use of OS X's fullscreen and makes it possible to get behavior similar to the behavior back when homebrew included a fullscreen patch.

And again, this is stuff coming down the pipe from upstream anyway. This just pulls in the current configurable behavior from their repo. With this patch applied you can switch to the old fullscreen behavior by setting:

(setq ns-use-native-fullscreen nil)
@jinn8522
jinn8522 commented Nov 5, 2013

Wonderful work.thanks for your work

@adamv adamv was assigned Nov 5, 2013
@adamv
Contributor
adamv commented Nov 5, 2013

@mikemcquaid any objection to me pulling this?

@MikeMcQuaid
Member

@adamv If you want it, sure. I'd rather we waited given it required "minimal changes" that could break other things.

@adamv
Contributor
adamv commented Nov 6, 2013

@mikemcquaid I don't use this feature myself, no

@adamv
Contributor
adamv commented Nov 6, 2013

Since this patch is based on upstream, I want to pull it in since it is a widely requested feature.

@scotchi can you rebase on the current emacs formula?

@scotchi scotchi Backport Emacs HEAD's fullscreen mode option
This makes it possible to bypass OS X's fullscreen mode.  The changes
were pulled from Emacs's bzr repository with minimal changes to get
them to work with 24.3
ceeb6ff
@scotchi
Contributor
scotchi commented Nov 6, 2013

Ok, I reworked the commit against the current homebrew master.

@scotchi
Contributor
scotchi commented Nov 6, 2013

Oh, and for the record, there was no original code that I had to rework for this -- it was just a matter of moving a couple of blocks around to a slightly different place in the file where diff wasn't smart enough to make them apply cleanly.

@adamv
Contributor
adamv commented Nov 7, 2013

"rework" was too strong a word perhaps, I just meant "rebase".

@adamv adamv added a commit that closed this pull request Nov 7, 2013
@scotchi @adamv scotchi + adamv emacs: backport fullscreen mode from HEAD
This makes it possible to bypass OS X's fullscreen mode.  The changes
were pulled from Emacs's bzr repository with minimal changes to get
them to work with 24.3

Closes #23729.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
b9d7a7a
@adamv adamv closed this in b9d7a7a Nov 7, 2013
@yriveiro yriveiro added a commit to yriveiro/homebrew that referenced this pull request Nov 26, 2013
@scotchi @yriveiro scotchi + yriveiro emacs: backport fullscreen mode from HEAD
This makes it possible to bypass OS X's fullscreen mode.  The changes
were pulled from Emacs's bzr repository with minimal changes to get
them to work with 24.3

Closes #23729.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
97cfa5f
@dandavison

@scotchi Thanks very much, much appreciated! 🎆

@ehershey ehershey added a commit to ehershey/homebrew that referenced this pull request Apr 4, 2014
@scotchi @ehershey scotchi + ehershey emacs: backport fullscreen mode from HEAD
This makes it possible to bypass OS X's fullscreen mode.  The changes
were pulled from Emacs's bzr repository with minimal changes to get
them to work with 24.3

Closes #23729.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
bf08417
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.