This repository has been archived by the owner. It is now read-only.

opam 1.1.0 #24086

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants
Contributor

avsm commented Nov 8, 2013

Update for OPAM 1.1.0. Main Formula changes are:

Contributor

adamv commented Nov 8, 2013

Failing on brew bot:

==> make
Error: opam did not build
Contributor

avsm commented Nov 8, 2013

Is there any way to get the detailed logs out of the brewbot?

Logs:
     /private/tmp/brew-test-bot/pulls/opam/01.configure
     /private/tmp/brew-test-bot/pulls/opam/02.make
     /private/tmp/brew-test-bot/pulls/opam/config.log

It works for me on my local Mavericks, so I'm not sure how to go about debugging this otherwise.

Contributor

avsm commented Nov 8, 2013

I'm a bit stumped about where the errors are going in this buildbot. I introduced a deliberate error in the last commit (clang -v) which causes this on my system:

==> clang -v
Apple LLVM version 5.0 (clang-500.2.79) (based on LLVM 3.3svn)
Target: x86_64-apple-darwin13.0.0
Thread model: posix
 "/Library/Developer/CommandLineTools/usr/bin/ld" -demangle -dynamic -arch x86_64 -macosx_version_min 10.9.0 -o a.out -L/usr/local/lib -L/opt/X11/lib -headerpad_max_install_names -lSystem /Library/Developer/CommandLineTools/usr/bin/../lib/clang/5.0/lib/darwin/libclang_rt.osx.a
Undefined symbols for architecture x86_64:
  "_main", referenced from:
     implicit entry/start for main executable
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

But in the buildbot output at http://bot.brew.sh/job/Homebrew%20Pull%20Requests/4263/version=mavericks/testReport/junit/brew-test-bot/mavericks/install_opam/

==> clang -v
Error: opam did not build

Is there any way to get the verbose logs out of it?

Owner

MikeMcQuaid commented Nov 8, 2013

@avsm Can you make a screenshot of what you see at that URL?

Contributor

avsm commented Nov 8, 2013

Sure;
brewbot-ss

Here's a text dump of everything after the OCaml compilation.

==> Installing opam
==> Downloading https://github.com/ocaml/opam/archive/1.1.0.tar.gz
Already downloaded: /Library/Caches/Homebrew/opam-1.1.0.tar.gz
tar xf /Library/Caches/Homebrew/opam-1.1.0.tar.gz
==> ./configure --prefix=/usr/local/Cellar/opam/1.1.0
checking for gcc... clang
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether clang accepts -g... yes
checking for clang option to accept ISO C89... none needed
checking for ocamlc... ocamlc
OCaml version is 4.01.0
OCaml library path is /usr/local/lib/ocaml
checking for ocamlopt... ocamlopt
checking for ocamlc.opt... ocamlc.opt
checking for ocamlopt.opt... ocamlopt.opt
checking for ocaml... ocaml
checking for ocamldep... ocamldep
checking for ocamlmktop... ocamlmktop
checking for ocamlmklib... ocamlmklib
checking for ocamldoc... ocamldoc
checking for ocamlbuild... ocamlbuild
checking for camlp4... camlp4
checking for camlp4o... camlp4o
checking for camlp4of... camlp4of
checking for camlp4oof... camlp4oof
checking for camlp4orf... camlp4orf
checking for camlp4prof... camlp4prof
checking for camlp4r... camlp4r
checking for camlp4rf... camlp4rf
checking for gawk... no
checking for mawk... no
checking for nawk... no
checking for awk... awk
checking for curl... curl
configure: creating ./config.status
config.status: creating Makefile.config
config.status: creating src/core/opamVersion.ml
config.status: creating doc/man-ext/opam-check.md

Executables will be installed in /usr/local/Cellar/opam/1.1.0/bin
Manual pages will be installed in /usr/local/Cellar/opam/1.1.0/share/man
==> ls -la
total 648
drwxr-xr-x  29 brew  wheel     986 Nov  8 18:27 .
drwx------   3 brew  wheel     102 Nov  8 18:26 ..
-rw-r--r--   1 brew  wheel     545 Nov  7 18:04 .gitignore
-rw-r--r--   1 brew  wheel       6 Nov  7 18:04 .ocp-indent
-rwxr-xr-x   1 brew  wheel     582 Nov  7 18:04 .travis-ci.sh
-rw-r--r--   1 brew  wheel      43 Nov  7 18:04 .travis.yml
-rw-r--r--   1 brew  wheel     316 Nov  7 18:04 AUTHORS
-rw-r--r--   1 brew  wheel   12827 Nov  7 18:04 CHANGES
-rw-r--r--   1 brew  wheel     440 Nov  7 18:04 CONTRIBUTING
-rw-r--r--   1 brew  wheel   43717 Nov  7 18:04 LICENSE
-rw-r--r--   1 brew  wheel     610 Nov  7 18:04 META.in
-rw-r--r--   1 brew  wheel    6094 Nov  7 18:04 Makefile
-rw-r--r--   1 brew  wheel     122 Nov  8 18:27 Makefile.config
-rw-r--r--   1 brew  wheel     100 Nov  7 18:04 Makefile.config.in
-rw-r--r--   1 brew  wheel    3638 Nov  7 18:04 README.md
-rw-r--r--   1 brew  wheel   11036 Nov  8 18:27 config.log
-rwxr-xr-x   1 brew  wheel   24876 Nov  8 18:27 config.status
-rwxr-xr-x   1 brew  wheel  165773 Nov  7 18:04 configure
-rw-r--r--   1 brew  wheel    1798 Nov  7 18:04 configure.ac
-rw-r--r--   1 brew  wheel    1039 Nov  7 18:04 depends.ocp.in
drwxr-xr-x   8 brew  wheel     272 Nov  7 18:04 doc
drwxr-xr-x   8 brew  wheel     272 Nov  7 18:04 jenkins
drwxr-xr-x   4 brew  wheel     136 Nov  7 18:04 m4
drwxr-xr-x   9 brew  wheel     306 Nov  7 18:04 ocp-build
-rw-r--r--   1 brew  wheel     101 Nov  7 18:04 opam.install
drwxr-xr-x  12 brew  wheel     408 Nov  7 18:04 shell
drwxr-xr-x   9 brew  wheel     306 Nov  7 18:04 src
drwxr-xr-x   5 brew  wheel     170 Nov  7 18:04 src_ext
drwxr-xr-x  10 brew  wheel     340 Nov  7 18:04 tests
==> make
Error: opam did not build
==> Configuration
HOMEBREW_VERSION: 0.9.5
HEAD: 256d739b37e92a3a2199fa8f02527df721fbc2d1
CPU: 8-core 64-bit ivybridge
OS X: 10.9-x86_64
Xcode: 5.0.1
CLT: 5.0.1.0.1.1382131676
X11: 2.7.5_rc4 => /opt/X11
==> ENV
HOMEBREW_CC: clang
HOMEBREW_CXX: clang++
MAKEFLAGS: -j8
CMAKE_PREFIX_PATH: /usr/local
CMAKE_INCLUDE_PATH: /opt/X11/include/freetype2:/usr/include/libxml2:/opt/X11/include
CMAKE_LIBRARY_PATH: /opt/X11/lib
PKG_CONFIG_LIBDIR: /usr/lib/pkgconfig:/usr/local/Library/ENV/pkgconfig/10.9:/opt/X11/lib/pkgconfig:/opt/X11/share/pkgconfig
HOMEBREW_VERBOSE: 1
HOMEBREW_GIT: /Applications/Xcode.app/Contents/Developer/usr/bin/git
ACLOCAL_PATH: /opt/X11/share/aclocal
PATH: /usr/local/Library/ENV/4.3:/usr/local/opt/objective-caml/bin:/opt/X11/bin:/usr/bin:/bin:/usr/sbin:/sbin

Logs:
     /private/tmp/brew-test-bot/pulls/opam/01.configure
     /private/tmp/brew-test-bot/pulls/opam/02.ls
     /private/tmp/brew-test-bot/pulls/opam/03.make
     /private/tmp/brew-test-bot/pulls/opam/config.log

These open issues may also help:
    https://github.com/mxcl/homebrew/pull/24086


Page generated: Nov 8, 2013 6:37:08 PMREST APIJenkins ver. 1.538

@ghost ghost assigned adamv Nov 8, 2013

yminsky commented Nov 9, 2013

Hmm. I just built this on my OS X 10.9 laptop, and it worked fine. In particular, I did it by running this command:

brew install https://raw.github.com/avsm/homebrew/a4c3194f3443faadb9c56b83b6010422a5d05d91/Library/Formula/opam.rb

Is the error here perhaps somehow localized to the buildbot?

@adamv adamv and 1 other commented on an outdated diff Nov 10, 2013

Library/Formula/opam.rb
@@ -2,17 +2,18 @@
class Opam < Formula
homepage 'https://github.com/OCamlPro/opam'
- url 'https://github.com/OCamlPro/opam/archive/1.0.0.tar.gz'
- sha1 '5e126f71c7e0caff3b61a751ef09dd66892720ae'
+ url 'https://github.com/ocaml/opam/archive/1.1.0.tar.gz'
@adamv

adamv Nov 10, 2013

Contributor

Presumably the homepage should also be the same repo as url and head?

@avsm

avsm Nov 11, 2013

Contributor

Fixed to https://opam.ocaml.org in rebased push

Owner

MikeMcQuaid commented Nov 10, 2013

@jacknagel Is this related to verbosity tweaking?

Contributor

jacknagel commented Nov 11, 2013

I'll take a look.

Contributor

jacknagel commented Nov 11, 2013

Hmm, I can't reproduce this exact failure. It does seem to fail about 1 out of every 10 times with "Error: The file primitives.cmo is not a bytecode object file", though.

@adamv adamv and 1 other commented on an outdated diff Nov 11, 2013

Library/Formula/opam.rb
depends_on "objective-caml"
def install
system "./configure", "--prefix=#{prefix}"
+ system "ls", "-la"
@adamv

adamv Nov 11, 2013

Contributor

Lol, what is this ls for?

@avsm

avsm Nov 11, 2013

Contributor

That was me pushing debug notes to figure out why the buildbot was complaining. I've removed them in the rebased push

Contributor

avsm commented Nov 11, 2013

I've added a ENV.deparallelize, as that's the usual reason for the occasional cmo corruption that @jacknagel sees (although I couldn't reproduce on my Mac after about 20 builds in a loop just now). Also pushed a clean rebased version of the patch.

Contributor

jacknagel commented Nov 11, 2013

I wouldn't be opposed to just pulling this, since it seems to work locally for people.

Contributor

avsm commented Nov 11, 2013

That would be useful, as we've released https://realworldocaml.org this morning and are getting a large influx of new OCaml users at the moment. The new version is greatly preferred for them (assuming it compiles, that is)

@jacknagel jacknagel closed this in 2411064 Nov 11, 2013

Contributor

jacknagel commented Nov 11, 2013

I pulled it, we'll see what happens I guess.

@avsm avsm deleted the avsm:opam11-release branch Nov 11, 2013

yriveiro added a commit to yriveiro/homebrew that referenced this pull request Nov 26, 2013

opam 1.1.0
Closes #24086.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

ehershey added a commit to ehershey/homebrew that referenced this pull request Apr 4, 2014

opam 1.1.0
Closes #24086.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 17, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.